Zone Index is discarded for IPv4-mapped IPv6 (transitional) addresses

[JamesMGreene]

Zone Index is discarded for IPv4-mapped IPv6 (transitional) addresses

var ipaddr = require('ipaddr.js')

addr = ipaddr.parse('::ff:ffff:c0a8:101%eth0')
// IPv6 { parts: [ 0, 0, 0, 0, 255, 65535, 49320, 257 ], zoneId: 'eth0' }

addr = ipaddr.parse('::ffff:c0a8:101%z')
// IPv6 { parts: [ 0, 0, 0, 0, 0, 65535, 49320, 257 ], zoneId: 'z' }

// This result is missing its zone index "map"
addr = ipaddr.parse('::ffff:192.168.1.1%map')
// IPv6 { parts: [ 0, 0, 0, 0, 0, 65535, 49320, 257 ] }

cc: @silverwind

[silverwind]

Something about the transitional regexp not matching the zoneId. Now if only I knew what match[1][0..-2] does in CoffeeScript :)

[JamesMGreene]

I think I fixed it but I'm trying to figure out where to add a unit test for this one.

[JamesMGreene]

And match[1][0..-2] somehow seems to translate to match[1].slice(0, -1). Oh, CoffeeScript.... 😕

[silverwind]

Here's my version of the fix, but go ahead and commit/PR yours:

   else if match = string.match(ipv6Regexes['transitional'])
-    addr = expandIPv6(match[1][0..-2], 6)
+    addr = expandIPv6(match[1][0..-2] + (match[6] || ''), 6)
     if addr.parts