Fix existing layouts breaking as of 1.0.9 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#469 broke existing layouts. This PR rectifies that.
|
@voidgraphics @toonvandenbos good fix, existing layouts broke. |
toonvandenbos
approved these changes
Jul 6, 2023
|
@toonvandenbos needs a tagged version / release I think. |
|
We're looking into a few related fixes and PRs in order to group everything in a single release. |
|
Hmm alright, do you have any idea when will things be released? |
|
@jsmit99 You can use a composer patch in the meantime, until a version is tagged. |
|
Hmm but it shouldnt take to much time to create a minor release? It's not working for latest nova now. |
|
@jsmit99 Use |
|
Please revert this. |
Why revert this fix that fixes the defect? |
|
@mabdullahsari See this issue, I'm experiencing exactly the same since this update > #475. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#469 broke existing layouts. This PR rectifies that.