Fixing file validation rules #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged? Any movement on this? |
|
Tested the fix and it looks like it is working for my cases. Could this be merged? |
|
Hi all, sorry for the delay. This PR is quite interesting, will give it a closer look. |
|
Thanks @michaelbaril! I did not have much time to test if this approach could be generalized to all input attributes or if it should stay file-specific. Feel free to take a look at this if you have the opportunity. |
This was referenced Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Validation rules for file attributes are not applied correctly since the name of the flexible attribute is not the actual name of the file in the request. (issues #112, #238)
This fixes the issue, hopefully.