refactor: only implement regex syntax validation once

whisperfish · Oct 15, 2020 · 66759a1 · 66759a1
1 parent 6ef21c0
commit 66759a1
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/metadata/loader.rs b/src/metadata/loader.rs
@@ -633,9 +633,7 @@ fn text<R: BufRead>(reader: &mut Reader<R>, name: &[u8]) -> Result<String, error
 fn text_check_regex<R: BufRead>(reader: &mut Reader<R>, name: &[u8]) -> Result<String, error::LoadMetadata> {
 	let regex_source = text(reader, name)?;
 	// check regular expression syntax
-	if let Err(err) = regex_syntax::Parser::new().parse(&regex_source) {
-		return Err(error::LoadMetadata::RegexSyntax(err));
-	}
+	check_regex(&regex_source)?;
 	Ok(regex_source)
 }