Re-flatten crate structure and get rid of PushService trait #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step to refactor PushService and split the push_service.rs file in many smaller parts.
gferon
force-pushed
the
push-service-trait-no-more
branch
from
8295bc8 to
cfd566b
Compare
This was referenced Oct 15, 2024
Merged
rubdos
reviewed
Oct 17, 2024
Comment on lines
-49
to
-54
| ## Feature flags for libsignal-service | ||
|
|
||
| | Feature flag | Description | | ||
| | ---------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | `unsend-futures` | This feature removes the `Send` requirement on returned futures. Enabling this flag may be necessary for interoperability with other libraries that don't support `Send` such as actix. | | ||
|
|
There was a problem hiding this comment.
I'm not sure whether WF will be compatible for now without the Unsend feature.
There was a problem hiding this comment.
Ah, I can definitely check that. It was my understanding that this was only for libsignal-service-actix. I'll double check.
There was a problem hiding this comment.
with whisperfish/whisperfish@e93ed19 I can confirm my initial suspicion, we can remove unsend-futures.
Checking whisperfish v0.6.0-dev (/Users/gferon/Developer/signal/whisperfish/whisperfish)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.52s
Co-authored-by: Ruben De Smet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the actix implementation is not used anymore, and makes changes to the HTTP layer harder, I'm suggesting this big refactoring. No logic has changed, and this is a pure copy-pasta from the contents of
libsignal-service-hyper.Among the benefits stand out:
async_trait(and static dispatch)httptypes instead of having our own (weak) abstraction layerThis is a first step to refactor
PushServiceand split thepush_service.rsfile in many smaller (and more readable) parts.We can also start exposing different basic feature flags for toggling the TLS layer (maybe it is interesting to
whisperfishto use OpenSSL?).You can see the type of necessary changes downstream to
whisperfishorpresage(not that many) - whisperfish/presage#272