Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix clippy 1.81 #323

Merged
merged 3 commits into from
Sep 30, 2024
Merged

chore: fix clippy 1.81 #323

merged 3 commits into from
Sep 30, 2024

Conversation

boxdot
Copy link
Contributor

@boxdot boxdot commented Sep 20, 2024

No description provided.

Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

libsignal-service/examples/storage.rs Outdated Show resolved Hide resolved
libsignal-service/src/messagepipe.rs Show resolved Hide resolved
@rubdos
Copy link
Member

rubdos commented Sep 30, 2024

@boxdot kind ping for the requested changes; maybe it wasn't clear from the notification that it was a change request :'-)

@boxdot
Copy link
Contributor Author

boxdot commented Sep 30, 2024

@boxdot kind ping for the requested changes; maybe it wasn't clear from the notification that it was a change request :'-)

Thank you for reminding me. I got carried away.

@rubdos
Copy link
Member

rubdos commented Sep 30, 2024

Lint reasons don't seem to be stabilized yet in 1.75, any chance we can put the reason behind a nightly flag? Sounds a bit wrong to bump MSRV for this :'-)

(Sailfish is on 1.75 still, and will be for at least half a year I fear)

@boxdot
Copy link
Contributor Author

boxdot commented Sep 30, 2024

Lint reasons don't seem to be stabilized yet in 1.75, any chance we can put the reason behind a nightly flag? Sounds a bit wrong to bump MSRV for this :'-)

(Sailfish is on 1.75 still, and will be for at least half a year I fear)

I think it is pragmatic to remove the reasons here. They are kind of obvious from the description of the lint.

@rubdos
Copy link
Member

rubdos commented Sep 30, 2024

They are kind of obvious from the description of the lint.

Description and position make it clear, indeed. Thank you!

@rubdos rubdos enabled auto-merge September 30, 2024 08:51
@boxdot boxdot requested a review from rubdos September 30, 2024 09:04
@rubdos rubdos merged commit 2327c23 into whisperfish:main Sep 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants