Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keys sync message #310

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Add Keys sync message #310

merged 4 commits into from
Oct 3, 2024

Conversation

direc85
Copy link
Contributor

@direc85 direc85 commented Jul 14, 2024

Take two, intentionally (for development convenience) branched of an old commit - the one Whisperfish main currently uses.

I tried to remove passing self-recipient, but couldn't figure out a way to get it in the method. I think that would require setting self service address to sender, which would break API, so I'm not delving into that currently.

Real-world tests performed:

  • Linking Signal Desktop (tested with Whisperfish -> SD)
  • Responding to Signal Desktop Keys sync request
  • Sending a Keys sync request

@direc85
Copy link
Contributor Author

direc85 commented Sep 8, 2024

Added WIP for MasterKey and StorageServiceKey, as well as MasterKeyStorage, which is probably done in some funky manner. Improvements and corrections welcome...

@gferon
Copy link
Collaborator

gferon commented Sep 9, 2024

Thanks! At the risk of missing the point, why was this suddenly needed? 😄

@direc85
Copy link
Contributor Author

direc85 commented Sep 10, 2024

These are needed to properly support the Keys sync message, which is needed for linking nowadays... Ruben suggested making these into a trait, I'm not at all sure I did that in a good way.

Basically this part should be quite ready, but there's still the "where are these actually used" side of things...

@direc85
Copy link
Contributor Author

direc85 commented Sep 29, 2024

We still must test this code, but review-wise this PR can be considered ready.

@direc85 direc85 marked this pull request as ready for review September 29, 2024 22:38
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 51.21951% with 20 lines in your changes missing coverage. Please review.

Project coverage is 23.72%. Comparing base (3b8656a) to head (b8d7761).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
libsignal-service/src/master_key.rs 51.21% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   16.77%   23.72%   +6.94%     
==========================================
  Files          36       32       -4     
  Lines        3111     1888    -1223     
==========================================
- Hits          522      448      -74     
+ Misses       2589     1440    -1149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@direc85 direc85 requested review from rubdos and gferon October 2, 2024 18:58
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some generalizations, otherwise looking clean to me! :-)

libsignal-service/src/master_key.rs Outdated Show resolved Hide resolved
libsignal-service/src/master_key.rs Outdated Show resolved Hide resolved
Co-authored-by: Ruben De Smet <[email protected]>
@direc85 direc85 merged commit 65b51db into main Oct 3, 2024
19 checks passed
@direc85 direc85 deleted the keys-wf branch October 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants