-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keys
sync message
#310
Conversation
Added WIP for MasterKey and StorageServiceKey, as well as MasterKeyStorage, which is probably done in some funky manner. Improvements and corrections welcome... |
Thanks! At the risk of missing the point, why was this suddenly needed? 😄 |
These are needed to properly support the Keys sync message, which is needed for linking nowadays... Ruben suggested making these into a trait, I'm not at all sure I did that in a good way. Basically this part should be quite ready, but there's still the "where are these actually used" side of things... |
We still must test this code, but review-wise this PR can be considered ready. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 16.77% 23.72% +6.94%
==========================================
Files 36 32 -4
Lines 3111 1888 -1223
==========================================
- Hits 522 448 -74
+ Misses 2589 1440 -1149 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some generalizations, otherwise looking clean to me! :-)
Co-authored-by: Ruben De Smet <[email protected]>
Take two, intentionally (for development convenience) branched of an old commit - the one Whisperfish
main
currently uses.I tried to remove passing self-recipient, but couldn't figure out a way to get it in the method. I think that would require setting self service address to sender, which would break API, so I'm not delving into that currently.
Real-world tests performed:
Keys
sync requestKeys
sync request