remove reason because msrv is too low

whisperfish · Sep 30, 2024 · bb5212a · bb5212a
1 parent f015dce
commit bb5212a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 28 deletions.
diff --git a/libsignal-service/examples/storage.rs b/libsignal-service/examples/storage.rs
@@ -16,10 +16,7 @@ impl ExampleStore {
 }
 
 #[async_trait::async_trait(?Send)]
-#[allow(
-    clippy::diverging_sub_expression,
-    reason = "combination of async_trait and todo"
-)]
+#[allow(clippy::diverging_sub_expression)]
 impl PreKeyStore for ExampleStore {
     /// Look up the pre-key corresponding to `prekey_id`.
     async fn get_pre_key(
@@ -48,10 +45,7 @@ impl PreKeyStore for ExampleStore {
 }
 
 #[async_trait::async_trait(?Send)]
-#[allow(
-    clippy::diverging_sub_expression,
-    reason = "combination of async_trait and todo"
-)]
+#[allow(clippy::diverging_sub_expression)]
 impl KyberPreKeyStore for ExampleStore {
     /// Look up the signed kyber pre-key corresponding to `kyber_prekey_id`.
     async fn get_kyber_pre_key(
@@ -81,10 +75,7 @@ impl KyberPreKeyStore for ExampleStore {
 }
 
 #[async_trait::async_trait(?Send)]
-#[allow(
-    clippy::diverging_sub_expression,
-    reason = "combination of async_trait and todo"
-)]
+#[allow(clippy::diverging_sub_expression)]
 impl SignedPreKeyStore for ExampleStore {
     /// Look up the signed pre-key corresponding to `signed_prekey_id`.
     async fn get_signed_pre_key(
@@ -105,10 +96,7 @@ impl SignedPreKeyStore for ExampleStore {
 }
 
 #[async_trait::async_trait(?Send)]
-#[allow(
-    clippy::diverging_sub_expression,
-    reason = "combination of async_trait and todo"
-)]
+#[allow(clippy::diverging_sub_expression)]
 impl KyberPreKeyStoreExt for ExampleStore {
     async fn store_last_resort_kyber_pre_key(
         &mut self,
@@ -150,10 +138,7 @@ impl KyberPreKeyStoreExt for ExampleStore {
 }
 
 #[async_trait::async_trait(?Send)]
-#[allow(
-    clippy::diverging_sub_expression,
-    reason = "combination of async_trait and todo"
-)]
+#[allow(clippy::diverging_sub_expression)]
 impl IdentityKeyStore for ExampleStore {
     /// Return the single specific identity the store is assumed to represent, with private key.
     async fn get_identity_key_pair(
@@ -209,10 +194,7 @@ impl IdentityKeyStore for ExampleStore {
 }
 
 #[async_trait::async_trait(?Send)]
-#[allow(
-    clippy::diverging_sub_expression,
-    reason = "combination of async_trait and todo"
-)]
+#[allow(clippy::diverging_sub_expression)]
 impl PreKeysStore for ExampleStore {
     /// ID of the next pre key
     async fn next_pre_key_id(&self) -> Result<u32, SignalProtocolError> {

diff --git a/libsignal-service/src/messagepipe.rs b/libsignal-service/src/messagepipe.rs
@@ -138,10 +138,7 @@ impl MessagePipe {
 /// WebSocketService that panics on every request, mainly for example code.
 pub struct PanicingWebSocketService;
 
-#[allow(
-    clippy::diverging_sub_expression,
-    reason = "combination of async_trait and todo"
-)]
+#[allow(clippy::diverging_sub_expression)]
 #[cfg_attr(feature = "unsend-futures", async_trait::async_trait(?Send))]
 #[cfg_attr(not(feature = "unsend-futures"), async_trait::async_trait)]
 impl WebSocketService for PanicingWebSocketService {