Handle missing self.options for whipper cd info #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeLametta
changed the title
self.options for whipper cd info
JoeLametta
force-pushed
the
bugfix/issue-375-cd-info-no-attribute
branch
from
23e0cc3 to
4387513
Compare
The attributes working_directory, disc_template, output_directory and offset are not defined during whipper cd info and they are only needed for ripping. self.program.getTable doesn't need output_path to gather the tocfile. Therefore, this part is excluded, if the attributes don't exist and an offset of 0 is used. Fixes issue #375. Co-authored-by: gorgobacka <[email protected]> Signed-off-by: JoeLametta <[email protected]> Signed-off-by: gorgobacka <[email protected]>
JoeLametta
force-pushed
the
bugfix/issue-375-cd-info-no-attribute
branch
from
4387513 to
993dd6c
Compare
This was referenced Oct 26, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attributes
working_directory,disc_template,output_directoryandoffsetare not defined duringwhipper cd infoand they are only needed for ripping, andself.program.getTabledoesn't needoutput_pathto gather the tocfile.Therefore, this part is excluded, if the attributes don't exist and an offset of 0 is used.
(Not tested yet. But I expect that it will work.)
Fixes issue #375.