Make whipper not break on missing release type #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freso
force-pushed
the
bugfix/issue-396-no-mb-release-group-type
branch
from
7fb848b to
9615405
Compare
See #396 Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Freso
force-pushed
the
bugfix/issue-396-no-mb-release-group-type
branch
from
9615405 to
8209927
Compare
Fixes #396 Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Freso
commented
May 2, 2019
| @@ -1,5 +1,5 @@ | |||
| # -*- Mode: Python; test-case-name: whipper.test.test_common_mbngs -*- | |||
| # vi:si:et:sw=4:sts=4:ts=4 | |||
| # vi:si:et:sw=4:sts=4:ts=4:set fileencoding=utf-8 | |||
There was a problem hiding this comment.
The encoding is required to be defined due to the “Ö” in the comment to the new test.
Freso
commented
May 2, 2019
Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Freso
force-pushed
the
bugfix/issue-396-no-mb-release-group-type
branch
from
b4aec85 to
bf8daf1
Compare
JoeLametta
approved these changes
May 3, 2019
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #396