Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docstrings #389

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Improve docstrings #389

merged 1 commit into from
Feb 22, 2020

Conversation

JoeLametta
Copy link
Collaborator

#387 (comment)

Depends on #387.

@JoeLametta JoeLametta force-pushed the bugfix/improve-docstrings branch 3 times, most recently from 211a2b6 to 37fefb3 Compare March 29, 2019 12:38
@JoeLametta
Copy link
Collaborator Author

@Freso Ping. 😉

@JoeLametta JoeLametta mentioned this pull request May 3, 2019
Merged
@Freso
Copy link
Member

Freso commented May 3, 2019

Ping. 😉

Let’s get #387 done and I’ll (try and remember to) come back to this then. :)

@Freso Freso self-requested a review May 3, 2019 14:31
@JoeLametta JoeLametta force-pushed the bugfix/improve-docstrings branch from 37fefb3 to 99d0735 Compare May 4, 2019 07:56
@JoeLametta
Copy link
Collaborator Author

Rebased on develop while solving merge conflicts.

@JoeLametta JoeLametta force-pushed the bugfix/improve-docstrings branch 2 times, most recently from a3466c8 to 01f9285 Compare November 27, 2019 18:31
ABCbum
ABCbum reviewed Jan 12, 2020
View reviewed changes
whipper/program/utils.py Outdated Show resolved Hide resolved
@JoeLametta JoeLametta force-pushed the bugfix/improve-docstrings branch from cd0ba48 to eee1a81 Compare January 29, 2020 11:48
@JoeLametta
Copy link
Collaborator Author

Added missing sign-off.

@JoeLametta
Improve docstrings
e56c636 
Signed-off-by: JoeLametta <[email protected]>
@JoeLametta JoeLametta force-pushed the bugfix/improve-docstrings branch from 2c5bbe1 to e56c636 Compare February 22, 2020 15:11
@JoeLametta JoeLametta changed the title WIP: Improve docstrings Improve docstrings Feb 22, 2020
@JoeLametta JoeLametta changed the title Improve docstrings Improve docstrings Feb 22, 2020
@JoeLametta JoeLametta merged commit 00b0692 into develop Feb 22, 2020
@JoeLametta JoeLametta deleted the bugfix/improve-docstrings branch February 22, 2020 15:24
@JoeLametta JoeLametta mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABCbum ABCbum ABCbum left review comments

@Freso Freso Awaiting requested review from Freso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeLametta @Freso @ABCbum