Add Track, Release Group, and Work MBIDs to ripped files #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://musicbrainz.org/doc/Track First part of #200 Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Freso
force-pushed
the
feature/issue-200-add-more-musicbrainz-identifiers
branch
from
514477a to
41b1b1f
Compare
See https://musicbrainz.org/doc/Release_Group Second part of #200 (MusicBrainz JSON test data dumps needed to be refreshed due to the new `includes` in the MusicBrainz web service call.) Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
We pull in the Release Group information now directly in the original MusicBrainz web service request, so no need to do further processing to get it. Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Before this bits and pieces of release and track metadata would be tested in the other test cases, but no test cases included all of them. Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Freso
changed the title
Freso
force-pushed
the
feature/issue-200-add-more-musicbrainz-identifiers
branch
from
29f1d54 to
ecd8c5c
Compare
Freso
changed the title
See https://musicbrainz.org/doc/Work Third and final and thus closes #200 Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Freso
force-pushed
the
feature/issue-200-add-more-musicbrainz-identifiers
branch
from
ecd8c5c to
364f024
Compare
|
Thank you so much, merged! |
JoeLametta
deleted the
feature/issue-200-add-more-musicbrainz-identifiers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #200
Currently only does Track MBIDs, since Release Group MBIDs will require to have
release-groupsadded to theincludes. Do we want to do that?