Let debug musicbrainzngs look up based on MusicBrainz Release ID in addition to Disc ID
#251
Labels
Accepted
Accepted issue on our roadmap
Feature
New feature
Good First Issue
Good for new contributors
Needed: patch
A pull request is required
Priority: low
Low priority
Sprintable
Small enough to sprint on
Milestone
Comments
|
Please see #249 |
JoeLametta
added
Accepted
ABCbum
pushed a commit
to ABCbum/whipper
that referenced
this issue
Dec 14, 2019
Add release_id argument [Fixes whipper-team#251] Signed-off-by: ABCbum <[email protected]>
ABCbum
pushed a commit
to ABCbum/whipper
that referenced
this issue
Dec 14, 2019
_getMetadata got changed so that it works with a release without specifying a discid getReleaseData is used in mblookup [Fixes whipper-team#251] Signed-off-by: ABCbum <[email protected]>
ABCbum
pushed a commit
to ABCbum/whipper
that referenced
this issue
Dec 15, 2019
Add new functionality to whipper mbloopkup command
to be able to look up release data based on releaseid
then prints it out in a sensible way.
This change makes:
- mblookup.py imports more from mbngs.py,
- mblookup takes 2 optional argument based on flags:
whipper mblookup -R/--release-id 12v12-242...
whipper mblookup -d/--disc-id 12v12-242...
- Whipper don't know what to tell user if the input is
not provided:
whipper mblookup -d
whipper mblookup -R
whipper mblookup -d -R
Resolves: whipper-team#251
Signed-off-by: ABCbum <[email protected]>
ABCbum
pushed a commit
to ABCbum/whipper
that referenced
this issue
Dec 15, 2019
This commit: - Creates a new function getReleaseMetadata() to lookup release metadata on its own as a separate function. - Modifies _getMetadata so that it still can return metadata even when discid argument is not provided. Solves: whipper-team#251 Signed-off-by: ABCbum <[email protected]>
ABCbum
pushed a commit
to ABCbum/whipper
that referenced
this issue
Dec 15, 2019
This commit: - Adds new mock function _mock_getReleaseMetadata. - Changes the way arguments is provided to mblookup.MBLoopkup() since the usage of mblookup is changed to be based on flags -R and -d. Solves: whipper-team#251 Signed-off-by: ABCbum <[email protected]>
|
Implemented in #432. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
whipper has a command for helping to find out what's going on with MusicBrainz release data called
whipper debug musicbrainzngs(@RecursiveForest is working on moving/renaming this though). This currently takes a Disc ID as its one argument.Sometimes you already know the specific Release you want but maybe still get wonky data in whipper, so the obvious thing to do would be look up what data whipper actually receives from MusicBrainz. The
debug musicbrainzngscommand would be the obvious way to do this, I think.The text was updated successfully, but these errors were encountered: