Skip to content

Commit

Permalink
Add checks and warnings for (known) cdparanoia's upstream bugs
Browse files Browse the repository at this point in the history
Fixes #495.

Signed-off-by: JoeLametta <[email protected]>
  • Loading branch information
JoeLametta committed Sep 17, 2020
1 parent 3acc3ff commit e4080bb
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions whipper/program/cdparanoia.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,23 @@ def start(self, runner):
stopTrack, common.framesToHMSF(stopOffset)),
self.path])
logger.debug('running %s', (" ".join(argv), ))
if offset > 587:
logger.warning(
"because of a cd-paranoia upstream bug whipper may fail to "
"work correctly when using offset values > 587 (current "
"value: %d) and print warnings like this: 'file size 0 did "
"not match expected size'. For more details please check the "
"following issues: "
"https://github.com/whipper-team/whipper/issues/234 and "
"https://github.com/rocky/libcdio-paranoia/issues/14", offset
)
if stopTrack == 99:
logger.warning(
"because of a cd-paranoia upstream bug whipper may fail to "
"rip the last track of a CD when it has got 99 of them. "
"For more details please check the following issue: "
"https://github.com/whipper-team/whipper/issues/302"
)
try:
self._popen = asyncsub.Popen(argv,
bufsize=bufsize,
Expand Down

0 comments on commit e4080bb

Please sign in to comment.