This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Add NPM scripts #31
Merged
Add NPM scripts #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-kobrzak
force-pushed
the
npm-scripts
branch
2 times, most recently
from
75c6698 to
bf3495a
Compare
| npm install | ||
| ``` | ||
|
|
||
| ## Workflow | ||
| 1. Run webpack-dev-server.js with Node. This will run `webpack-dev-server` with | ||
| HMR enabled on port 5000: | ||
| 1. Run `webpack-dev-server` acting as a static content HTTP server with hot |
There was a problem hiding this comment.
It would be more correct to say "acting as asset server".
chris-kobrzak
added
in progress
ready for review
and removed
ready for review
in progress
labels
|
Looks good 👍 |
Also drop requirement for globally available `webpack` and `karma` dependencies. NPM adds `node_modules/.bin` to its `PATH` and that means you don't need to worry about installing Node.js dependencies globally. The `npm run` command will use locally installed binaries instead.
You might want to go `npm run clean` before running the linter to prevent it from reporting on the Istanbul coverage JavaScript files.
cobacious
pushed a commit
that referenced
this pull request
Aug 27, 2015
Add NPM scripts - Resolves #31
|
Resolves #30 |
| "build": "webpack", | ||
| "clean": "rm -fr tmp/coverage/javascript/* && rm -fr dist/*", | ||
| "dev-server": "node webpack-dev-server.js", | ||
| "start": "http-server -p 5001", | ||
| "lint": "eslint --ignore-pattern dist ./; exit 0", |
There was a problem hiding this comment.
More background on the exit 0 hack: eslint/eslint#2409 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #30