Feat/missile class composition #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missile attributes/characteristics are now specified in one place, and are initialised in the missile constructor (proper composition) Missile attributes now use nested classes instead of friendship for private member access
grantramsay
force-pushed
the
feat/missile-class-composition
branch
from
c706c56 to
9efcb17
Compare
|
Will tidy this up and fix build later |
Add a reference to missiles graphics on each level to avoid having to check every actor in world to find missile graphics on a level
grantramsay
force-pushed
the
feat/missile-class-composition
branch
from
9efcb17 to
9a3de11
Compare
Missiles that don't move shouldn't be concerned with range
grantramsay
force-pushed
the
feat/missile-class-composition
branch
from
d6ea7a0 to
aaa6347
Compare
wheybags
requested changes
Mar 5, 2020
wheybags
reviewed
Mar 7, 2020
Update changelog Any player can use town portal Change mMissileGraphics to std::unordered_set Add comment on not using mMissileGraphics for game logic Add TODO for removing "additionalConstraints" after GameObject refactor Use std::numeric_limits<int32_t>::max() over INT32_MAX
grantramsay
force-pushed
the
feat/missile-class-composition
branch
from
a2d0016 to
d55b60a
Compare
wheybags
approved these changes
Mar 12, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the changes are just whitespace from the "Tidy namespaces" commit