Skip to content

Commit

Permalink
Post-review corrections: removing bits unrelated to issue kubernetes-…
Browse files Browse the repository at this point in the history
  • Loading branch information
wherka-ama committed Aug 17, 2022
1 parent dce9b27 commit 0945078
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cluster/internal/providers/podman/provision.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,12 +252,12 @@ func getProxyEnv(cfg *config.Cluster, networkName string) (map[string]string, er
return nil, err
}
noProxyList := append(subnets, envs[common.NOProxy])
// Add pod, service and control plane(API server) dns names to no_proxy to allow in cluster
// Add pod and service dns names to no_proxy to allow in cluster
// Note: this is best effort based on the default CoreDNS spec
// https://github.com/kubernetes/dns/blob/master/docs/specification.md
// Any user created pod/service hostnames, namespaces, custom DNS services
// are expected to be no-proxied by the user explicitly.
noProxyList = append(noProxyList, ".svc", ".svc.cluster", ".svc.cluster.local", strings.Join([]string{cfg.Name, "control-plane"}, "-"))
noProxyList = append(noProxyList, ".svc", ".svc.cluster", ".svc.cluster.local")
noProxyJoined := strings.Join(noProxyList, ",")
envs[common.NOProxy] = noProxyJoined
envs[strings.ToLower(common.NOProxy)] = noProxyJoined
Expand Down

0 comments on commit 0945078

Please sign in to comment.