Add support for external bluetooth devices #535

sylvieee-iot · 2024-07-14T21:32:33Z

Add support for external haptic bluetooth devices, in this case but*plugs. This works for all sorts of bluetooth but*plugs that use the common bluetooth protocol for BPs, and is also hooked to the Lua API so that you can make per-game scripts to activate and control your device.

This is early progress code, I need some more time to work on it and help if possible. Thanks.

sylvieee-iot · 2024-07-14T21:35:46Z

Also I need to implement some more Lua events for things like but*plug being connected, as it would make Lua scripts significantly easier to write. Now it's kind of hard to know when to start/stop rumbling the device.

sylvieee-iot · 2024-07-14T21:36:43Z

Example of the Lua API

rupees1_address = 0x050AF88
rupees2_address = 0x05879A0

device = 0  -- Device to buzz
force = 0.4 -- Force to use
vibration_time = 120 -- Number of frames to buzz buzz for
vibration_countdown = 0 -- Number of frames until we should stop buzzing
first = true-- Is this our first time counting rupees?

previous_rupees = 0 -- How many rupees did we have in the previous frame?
current_rupees = 0  -- How many rupees do we currently have?

Buzz.initHaptics() -- Initialize haptics subsytem
Buzz.connect()     -- Connect to device
Buzz.requestDeviceList()
Buzz.startScan()

function vibe()
    vibration_countdown = vibration_time

    Buzz.getDevices()
    Buzz.sendScalar(device, force)
end

function unvibe()
    Buzz.getDevices()
    Buzz.sendScalar(device, 0.0)
end

function getRupees() return Pand.read16(rupees1_address) end

function eventHandler(e)
    if (e == Pand.Frame) then
        if (first) then
            previous_rupees = getRupees()
            first = false
            return
        end

        previous_rupees = current_rupees
        current_rupees = getRupees()

        if (current_ruppes ~= previous_rupees) then vibe() end

        -- Ongoing vibration, count down
        if (vibration_countdown > 0) then 
            vibration_countdown = vibration_countdown - 1
            -- Stop vibrating if we're done
            if (vibration_countdown == 0) then unvibe() end
        end
    end
end

I think buzz is a pretty cute name xD

OFFTKP · 2024-07-14T22:27:55Z

Please merge this as soon as possible

sylvieee-iot · 2024-07-14T22:36:16Z

Please merge this as soon as possible

Yes I believe many people would love to feel the erotic sensations a toy can offer when combined with Lua scripts :3 😉

sylvieee-iot · 2024-07-14T22:36:41Z

Can you review @OFFTKP

OFFTKP · 2024-07-14T22:43:49Z

.gitmodules

@@ -70,6 +70,9 @@
 [submodule "third_party/capstone"]
 	path = third_party/capstone
 	url = https://github.com/capstone-engine/capstone
+[submodule "third_party/open-bp-cpp/third_party/IXWebSocket"]


You added this as a submodule, but not open-bp-cpp. We prefer to store stuff as submodules here so that when githubs go private we don't suffer any damages. Actually wait, that would have the opposite effect. What was I saying? Oh please add open-bp-cpp as a submodule instead

OPEN BP CPP IS HEAVILY MODIFIED AS I MADE IT GOOD WHILE IT WAS HORRIBLE BEFORE

I am sorry but I am not going to go through 20 thousand lines of code to make sure you didn't add a backdoor (heh get it?) somewhere in the program.

I dun geddit

Well you see, prior this year we had some "guys" that tried to implement a backdoor in the OSS project named XZ. Here, OFFTKP wants to make sure that the program stays secure. In order to do that, every PR that adds code must be analyzed by hand to prevent any attack of this kind. Reviewing code is an operation that take an exponential amount of time. The more line there is to review, the more time it takes. I totally understand that OFFTKP does not have the required time to analyze 20K lines of code. Only peoples employed in an enterprise would do this. If he/she is a hobbyist or a developer doing this on his/her free time, then he/she may not have this time.

Well you see, prior this year we had some "guys" that tried to implement a backdoor in the OSS project named XZ. Here, OFFTKP wants to make sure that the program stays secure. In order to do that, every PR that adds code must be analyzed by hand to prevent any attack of this kind. Reviewing code is an operation that take an exponential amount of time. The more line there is to review, the more time it takes. I totally understand that OFFTKP does not have the required time to analyze 20K lines of code. Only peoples employed in an enterprise would do this. If he/she is a hobbyist or a developer doing this on his/her free time, then he/she may not have this time.

https://en.m.wikipedia.org/wiki/Singular_they

I agree, either they (the author of this PR) rewrite to use the "official" branch of the library or they try to make a PR to make their branch of the library merged to the library itself.

1. https://en.m.wikipedia.org/wiki/Singular_they

Thank you, I am not en English people so I didn't know it.

Well you see, prior this year we had some "guys" that tried to implement a backdoor in the OSS project named XZ. Here, OFFTKP wants to make sure that the program stays secure. In order to do that, every PR that adds code must be analyzed by hand to prevent any attack of this kind. Reviewing code is an operation that take an exponential amount of time. The more line there is to review, the more time it takes. I totally understand that OFFTKP does not have the required time to analyze 20K lines of code. Only peoples employed in an enterprise would do this. If he/she is a hobbyist or a developer doing this on his/her free time, then he/she may not have this time.

A true 10X programmer like @OFFTKP would have no problem with 20K lines of code. A real 69X programmer like me would just look at the diff between upstream and my vendored version in a text editor 🤣

As a fellow 69X programmer, I confirmed that the files added was 100x improvement modification from the original https://github.com/dumbowumbo/buttplugCpp repository (in which is the officially supported binding of the Buttplug library) that is totally harmless and definitely not a backdoor.

OFFTKP · 2024-07-14T22:54:13Z

include/external_haptics_manager.hpp

+	SensorClass sensors;
+
+  public:
+	ExternalHapticsManager() : client("ws://127.0.0.1", 12345) {}


We shouldn't hardcode the address/port like that. More so, what if I want to receive haptic inputs from people all around the globe, do I have to modify the code myself to change the ip address my haptic device is hosted on? What is this, dwm?

This adds buttplug support not e-sex support bro

I don't know what that b word is or what e-sex is, please address the review comment

I don't know what that b word is or what e-sex is, please address the review comment

fucking e-virgin

Adding onto @OFFTKP's suggestion I would suggest adding UPnP support if the IP is 127.0.0.1 to automatically port forward the rumble device if it is hosted on the same networks and registering the public IP in a real time database such as firebase for any Panda3DS user to connect to.

https://github.com/cybergarage/mupnp-cc

OFFTKP · 2024-07-14T22:54:56Z

include/external_haptics_manager.hpp

+	ExternalHapticsManager() : client("ws://127.0.0.1", 12345) {}
+
+	void connect() {
+		client.connect([](const mhl::Messages message) {


What's the point of const when we are copying a value over anyway?

OFFTKP · 2024-07-14T22:55:44Z

include/external_haptics_manager.hpp

+	}
+
+	void stopDevice(int index) {
+		if (index < devices.size()) {


This would probably trigger a signed unsigned comparison warning

Don't care wtf

OFFTKP · 2024-07-14T22:56:51Z

CMakeLists.txt

+    include_directories(third_party/open-bp-cpp/include)
+    include_directories(third_party/open-bp-cpp/third_party/IXWebSocket/ixwebsocket)
+    add_subdirectory(third_party/open-bp-cpp)
+    target_link_libraries(AlberCore PRIVATE buttplugCpp)


This library doesn't really feel as a core component of Alber to justify being linked to the core library.

OFFTKP · 2024-07-14T23:05:05Z

src/lua.cpp

+	}
+
+	// clang-format off
+	static constexpr luaL_Reg functions[] = {


See comment above, also static constexpr doesn't make much sense to me anyway

constexpr makes it a constant expresison, static guarantees that it's allocated in static storage instead of copied on the stack when the function runs. This is why any LUTs you declare in a function should be declared as static constexpr and NOT plain constexpr.

This isn't in a function so it's gonna go in static storage anyway. However we should keep it as constexpr (even if it does literally nothing) so that we can claim we use modern C++. Also you missed a chance to use the X macros you love so much:

#define X(name) { #name, name##Thunk },

OFFTKP · 2024-07-14T23:07:03Z

src/lua.cpp

+			hapticsManager->sendScalar(device, value);
+		}
+
+		return 2;


Magic number

Sir this is how Lua thunks work, you return the number of return values

OFFTKP · 2024-07-14T23:07:11Z

src/lua.cpp

+			hapticsManager->stopDevice(device);
+		}
+
+		return 1;


Another magic number

OFFTKP · 2024-07-14T23:08:32Z

src/lua.cpp

+		return 0;
+	}
+
+#define HAPTICS_THUNK(func)                \


X macros are bad because they enable you to essentially have a very easy and portable way to generate boilerplate code and reduce duplicated code, thus leading to less source code cluttering. Wait why did I say they are bad?

lines of code = performance

OFFTKP · 2024-07-14T23:10:16Z

src/lua.cpp

+		return 1;
+	}
+
+	// clang-format off


What a tragedy

kamil-diy · 2024-07-16T23:40:27Z

buzz buzz

x4exr · 2024-11-01T14:39:27Z

src/lua.cpp

@@ -242,6 +245,80 @@ static int disassembleTeakThunk(lua_State* L) {
 	return 1;
 }

+#ifndef __ANDROID__
+// Haptics functions


I think you care a little

x4exr · 2024-11-01T14:39:53Z

src/lua.cpp

+		return 0;
+	}
+
+#define HAPTICS_THUNK(func)                \


lines of code = performance

wheremyfoodat · 2024-11-01T14:41:36Z

Why is this PR

x4exr · 2024-11-01T21:24:06Z

i didnt understand what that question was asking, which means I am a bumbling idiot :(

kamil-diy · 2024-11-03T10:38:01Z

the pr of all time

x4exr · 2024-11-04T00:02:40Z

the pr of all time

I feel like I know you from somewhere

kamil-diy · 2024-11-24T22:46:56Z

the pr of all time

I feel like I know you from somewhere

shhh no you dont

nonetrix · 2024-11-26T01:21:35Z

Finally always wanted this

wheremyfoodat · 2024-11-26T01:27:21Z

Finally always wanted this

Are you for real

KingKrouch · 2024-11-26T02:42:39Z

Ultrakill fans are having a field day right now modding in plug support into everything.

AlphaLovesYou · 2025-01-17T07:40:20Z

im still curious on the potential addition of shock collar support.
forgot to message our glorious leader about it. may he forgive me for my faliures.

VenomousSteam81 · 2025-01-19T05:12:15Z

I guess this is something to mess with later.

TruncatedDinoSour

LGTM

powdered-java · 2025-01-19T14:53:44Z

LGTM

ari no dont do this

TruncatedDinoSour · 2025-01-19T14:54:55Z

LGTM

ari no dont do this

I said what I said.

Looks. Good. To. Me.

MERGE THIS!!!

powdered-java · 2025-01-19T14:58:46Z

LGTM

ari no dont do this

I said what I said.

Looks. Good. To. Me.

MERGE THIS!!!

NO DO NOT, YOU DONT KNOW IF THERES A BACKDOOR INSIDE OR NOT!!!

NotAShelf · 2025-01-19T15:48:38Z

If there is a backdoor, I would say it's in the scope of this PR given the... technology it deals with.

This should be merged immediately.

Dishpit

the eight-space tabs make me want to go play in traffic

but otherwise: LGTM, merge it

caatge · 2025-01-19T17:16:07Z

omg this should be merged rn

TukanDev · 2025-01-19T18:44:50Z

LGTM

ari no dont do this

I said what I said.
Looks. Good. To. Me.
MERGE THIS!!!

NO DO NOT, YOU DONT KNOW IF THERES A BACKDOOR INSIDE OR NOT!!!

Backdoor is a builtin feature of this PR like it or not, wouldnt you agree that randomly activating "bluetooth device" would be beneficial! You never know when its gonna give you some fun.

BnDLett · 2025-01-19T20:51:45Z

merge this please

aidendotgg · 2025-01-20T00:49:21Z

I want my ass to rumble every time I catch a pokemon in pokemon white 2. please merge

shadersrs3 · 2025-01-20T09:52:37Z

Same, please merge ASAP

slxdy · 2025-01-20T16:44:23Z

There is no way they actually took this PR seriously... The era we live in

EvieYT · 2025-01-20T16:52:17Z

This must be merged immediately.

BnDLett · 2025-01-20T17:37:25Z

There is no way they actually took this PR seriously... The era we live in

Do you not take the PR seriously?

TruncatedDinoSour · 2025-01-20T17:39:47Z

There is no way they actually took this PR seriously... The era we live in

Do you not take the PR seriously?

This pull request is one of the most important PRs in Panda3DS history and must be merged if we expect Panda3DS to outlive 2025. I do not see Panda3DS being able to go on without the important functionality this PR implements. It is a very urgent issue that needs to be resolved as soon as possible and I urge every developer all around the 2D frisbee to advocate for its merging.

moonacutie · 2025-01-20T17:44:42Z

There is no way they actually took this PR seriously... The era we live in

Do you not take the PR seriously?

This pull request is one of the most important PRs in Panda3DS history

This is an understatement. It's the most important PR in the history of mankind.

nitrog0d · 2025-01-20T18:00:03Z

👽

TukanDev · 2025-01-20T19:23:29Z

👽

Oh hi nitro strange seeing you here

CoopTRUE · 2025-01-20T20:44:48Z

MERGE ASAP

slxdy · 2025-01-20T20:50:53Z

But in all seriousness, this really doesn't make sense. Wouldn't it be more acceptable to add support for plugins and THEN make it a third party plugin?
To give a fair comparison, imagine if Electron added official API for buttplugs, just because a random person decided to work on it.

ReDestroyDeR · 2025-01-21T00:34:38Z

But in all seriousness, this really doesn't make sense. Wouldn't it be more acceptable to add support for plugins and THEN make it a third party plugin? To give a fair comparison, imagine if Electron added official API for buttplugs, just because a random person decided to work on it.

electron adding native bp support seems legit 🤔

slxdy · 2025-01-21T00:38:23Z

Fck it. First one to make a ready PR for Electron adding buttplug API gets $50 on gh sponsors from me

qdot · 2025-01-21T02:07:11Z

Fck it. First one to make a ready PR for Electron adding buttplug API gets $50 on gh sponsors from me

As the lead dev of buttplug and the ex device interfaces lead on Firefox I would just like to say:

lol

lmao

time to build out a spec and idl for my own protocol i guess

(That said I do agree with the "this would be better as a plugin" argument but I'm also not one to get in the way of a shitpost)

Dishpit · 2025-01-21T02:36:59Z

Fck it. First one to make a ready PR for Electron adding buttplug API gets $50 on gh sponsors from me

NotReeceHarris · 2025-01-21T13:57:39Z

can finally cheat at chess on 3ds with my butt plug

Rawiros · 2025-01-21T21:48:54Z

this needs to be merged fr

shuntia · 2025-01-24T10:05:44Z

can finally cheat at chess on 3ds with my butt plug

you're still going to be a** if you get what I mean

bw8686

LGTM

sylvieee-iot added 14 commits May 2, 2024 20:28

Add external libraries

e8dc11c

Migrate bpcpp's package management

2243af8

Improv eexample

e6d6221

PoC

0bdc7f6

Add IXWebSockers to CMake for fixing bp client

3c1641a

Fix head

729efb5

improve colon

77959fa

stupid

fb26e5a

Fix stupid CMake

c2123c3

Fix websocket sunmodule

7dc70a2

8AM buttplug work

fea52db

Update main.cpp

4cdcb8a

I NEED SLEEP

eab5fd3

Merge branch 'master' into open-bp-cpp

13ee3a1

OFFTKP requested changes Jul 14, 2024

View reviewed changes

x4exr approved these changes Nov 1, 2024

View reviewed changes

TruncatedDinoSour approved these changes Jan 19, 2025

View reviewed changes

Dishpit approved these changes Jan 19, 2025

View reviewed changes

bw8686 approved these changes Jan 26, 2025

View reviewed changes

Add support for external bluetooth devices #535

Are you sure you want to change the base?

Add support for external bluetooth devices #535

Conversation

sylvieee-iot commented Jul 14, 2024 • edited Loading

sylvieee-iot commented Jul 14, 2024

sylvieee-iot commented Jul 14, 2024

OFFTKP commented Jul 14, 2024

sylvieee-iot commented Jul 14, 2024 • edited Loading

sylvieee-iot commented Jul 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OFFTKP Jul 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ProgrammerIn-wonderland Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sylvieee-iot Jul 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kamil-diy commented Jul 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wheremyfoodat commented Nov 1, 2024

x4exr commented Nov 1, 2024

kamil-diy commented Nov 3, 2024

x4exr commented Nov 4, 2024

kamil-diy commented Nov 24, 2024

nonetrix commented Nov 26, 2024

wheremyfoodat commented Nov 26, 2024

KingKrouch commented Nov 26, 2024

AlphaLovesYou commented Jan 17, 2025

VenomousSteam81 commented Jan 19, 2025

TruncatedDinoSour left a comment

Choose a reason for hiding this comment

powdered-java commented Jan 19, 2025

TruncatedDinoSour commented Jan 19, 2025

powdered-java commented Jan 19, 2025

NotAShelf commented Jan 19, 2025

Dishpit left a comment

Choose a reason for hiding this comment

caatge commented Jan 19, 2025

TukanDev commented Jan 19, 2025

BnDLett commented Jan 19, 2025

aidendotgg commented Jan 20, 2025

shadersrs3 commented Jan 20, 2025

slxdy commented Jan 20, 2025

EvieYT commented Jan 20, 2025

BnDLett commented Jan 20, 2025

TruncatedDinoSour commented Jan 20, 2025

moonacutie commented Jan 20, 2025 • edited Loading

nitrog0d commented Jan 20, 2025

TukanDev commented Jan 20, 2025

CoopTRUE commented Jan 20, 2025

slxdy commented Jan 20, 2025 • edited Loading

ReDestroyDeR commented Jan 21, 2025

slxdy commented Jan 21, 2025 • edited Loading

qdot commented Jan 21, 2025

Dishpit commented Jan 21, 2025

sylvieee-iot commented Jul 14, 2024 •

edited

Loading

sylvieee-iot commented Jul 14, 2024 •

edited

Loading

OFFTKP Jul 14, 2024 •

edited

Loading

ProgrammerIn-wonderland Jan 27, 2025 •

edited

Loading

sylvieee-iot Jul 14, 2024 •

edited

Loading

moonacutie commented Jan 20, 2025 •

edited

Loading

slxdy commented Jan 20, 2025 •

edited

Loading

slxdy commented Jan 21, 2025 •

edited

Loading