This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
Support document variables substitution in paths #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zteater
reviewed
Aug 26, 2020
| return strings; | ||
| } | ||
|
|
||
| // @VisibleForTesting |
There was a problem hiding this comment.
Can we remove this, if it is not needed?
There was a problem hiding this comment.
It's just to indicate why the relaxed access level. Want me to change it to a comment or leave it out?
Guava has an annotation like that but it has no functional use. Just for reading.
I was accidentally using the testing libraries one, but I'd prefer to keep the test library scope as test.
There was a problem hiding this comment.
Ah ok, apologies for the delay in responding. That should be fine.
zteater
suggested changes
Aug 26, 2020
Fix test setup
zteater
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables prefixing with a relative path, so preview of include directives also work in IDEA