Remove disused entries from error names table (2.8.1.) #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is correct, e.g., |
That's right, but this PR doesn't suggest removing that constant. What the table (2.8.1.) defines is the mapping from the error name to error code. e.g. I checked these mappings (of deprecated ones) by the following expression: [
new DOMException('foo', 'IndexSizeError').code,
new DOMException('foo', 'DOMStringSizeError').code,
new DOMException('foo', 'ValidationError').code,
new DOMException('foo', 'InvalidAccessError').code,
new DOMException('foo', 'NoDataAllowedError').code,
new DOMException('foo', 'TypeMismatchError').code
]The major 4 browsers all return |
domenic
approved these changes
Jan 15, 2021
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 15, 2021
In particular, this tests the deprecated ones, some removed ones, and some newer error names which intentionally don't have legacy error codes. See also whatwg/webidl#946. Closes #27151.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 19, 2021
…ames table, a=testonly Automatic update from web-platform-tests DOMException: test code mapping for all error names In particular, this tests the deprecated ones, some removed ones, and some newer error names which intentionally don't have legacy error codes. See also whatwg/webidl#946. Closes #27151. -- wpt-commits: 93c6faceda56025f1c96c0155990bf1d231dac9c wpt-pr: 27181
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 25, 2021
…ames table, a=testonly Automatic update from web-platform-tests DOMException: test code mapping for all error names In particular, this tests the deprecated ones, some removed ones, and some newer error names which intentionally don't have legacy error codes. See also whatwg/webidl#946. Closes #27151. -- wpt-commits: 93c6faceda56025f1c96c0155990bf1d231dac9c wpt-pr: 27181 UltraBlame original commit: 84dd97dc22528263ce280a59cb531b3ab2fed488
domenic
added a commit
to jsdom/domexception
that referenced
this pull request
Oct 3, 2021
domenic
added a commit
to jsdom/domexception
that referenced
this pull request
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No major browser implements these 3 error-name-to-error-code mappings in DOMException constructor. So this PR suggests removing these 3 entries from the table.
We found this while updating web platform test at web-platform-tests/wpt#27181.
cc @domenic