Check grammar is LL(1) as part of Travis builds #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobie
force-pushed
the
check-grammar
branch
4 times, most recently
from
377aead to
bdf8d8e
Compare
|
Now that @DmitrySoshnikov merged DmitrySoshnikov/syntax#49, this runs properly in Travis. |
domenic
approved these changes
Oct 11, 2017
| @@ -0,0 +1,48 @@ | |||
| const Grammar = require("syntax-cli").Grammar; | |||
check-grammar.js
Outdated
| function processRules(rules) { | ||
| const REGEXP = /(\s*:\n\s*)|\b(integer|float|identifier|string|whitespace|comment|other)\b|(\s*\n\s*)|(ε)/g; | ||
| return rules.map(rule => { | ||
| return rule.trim().replace(REGEXP, m => { |
There was a problem hiding this comment.
Nit: two spaces after return seems silly.
check-grammar.js
Outdated
| } | ||
|
|
||
| let path = process.argv[2]; | ||
| let html = require("fs").readFileSync(path, "utf8"); |
There was a problem hiding this comment.
Nit: seems nicer to put all require()s at the top
deploy.sh
Outdated
| @@ -13,7 +13,8 @@ if [[ "$TRAVIS_PULL_REQUEST" != "false" || "$TRAVIS_BRANCH" != "$SOURCE_BRANCH" | |||
| echo "Skipping deploy; just doing a build." | |||
| mkdir out | |||
| doCompile | |||
| exit 0 | |||
| node ./check-grammar.js ./out/index.html | |||
| exit $? | |||
There was a problem hiding this comment.
Why only check on pull requests?
I'd just put this inside doCompile. No need for exit $? then since we have done set -e above.
|
Best resource I found to truly understand how a LL(1) parser is supposed to work: https://courses.cs.washington.edu/courses/cse401/04sp/slides/03b-LL1-example.pdf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix existing conflicts.
Blocks on Remove reference to Closure, expose State instead DmitrySoshnikov/syntax#49.Preview | Diff