Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align WritableStream structure with ReadableStream structure #462

Closed
wants to merge 28 commits into from
Closed

Align WritableStream structure with ReadableStream structure #462

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
17c3b10
Align WritableStream structure with ReadableStream structure
tyoshino Dec 8, 2015
cfcb5f4
Some more work
tyoshino May 31, 2016
ae2e3f0
Brush up TransformStream implementation
tyoshino Jun 1, 2016
b8925a8
Updated some WritableStream test cases
tyoshino Jun 2, 2016
36f7aab
Some abort related test fixes
tyoshino Jun 2, 2016
487faf0
More text fix + fix on _writing flag bug
tyoshino Jun 2, 2016
8973296
Clean up
tyoshino Jun 2, 2016
0eda159
More fix on tests/writable-stream.js
tyoshino Jun 2, 2016
5c461ed
More fix
tyoshino Jun 2, 2016
3c26174
More text fix
tyoshino Jun 7, 2016
d7afc2c
Updated pipeTo algorithm
tyoshino Jun 9, 2016
84e8d14
Updating
tyoshino Jun 10, 2016
3aefe10
Fixed some more pipe-to tests
tyoshino Jul 4, 2016
210e594
Finished fixing pipe-to.js and pipe-to-options.js
tyoshino Jul 6, 2016
6c7ef8c
Fixed all pipe tests
tyoshino Jul 7, 2016
5154b7f
Fixed transform-stream.js test
tyoshino Jul 12, 2016
e7c63f2
More fix
tyoshino Jul 12, 2016
71a7bf4
All tests pass
tyoshino Jul 13, 2016
b417f8c
Relaxed lock release criteria and enabled skipped tests
tyoshino Jul 14, 2016
23f089f
Revert rethrow function change
tyoshino Jul 14, 2016
1ab52e7
Remove lines for debugging
tyoshino Jul 14, 2016
b6dad06
Style, typo fixes
tyoshino Jul 14, 2016
9330212
Fix assertion to allow releaseLock on a closing WritableStream
tyoshino Jul 14, 2016
7d44f01
Add more getWriter() tests
tyoshino Jul 14, 2016
00a9661
Use e => t.error(e)
tyoshino Jul 15, 2016
2c08015
Wrap t.error with lambda
tyoshino Jul 15, 2016
0039992
Simplify pipeTo()
tyoshino Jul 26, 2016
fd84ae6
Tweak
tyoshino Jul 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions reference-implementation/lib/readable-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ class ReadableStream {
// Do nothing
}
)
.catch(e => rethrowAssertionErrorRejection(e));
.catch(rethrowAssertionErrorRejection);

// Any failures will be handled by listening to reader.closed and dest.closed above.
// TODO: handle malicious dest.write/dest.close?
Expand Down Expand Up @@ -1034,7 +1034,7 @@ class ReadableStreamDefaultController {
}
}
)
.catch(e => rethrowAssertionErrorRejection(e));
.catch(rethrowAssertionErrorRejection);
}

get desiredSize() {
Expand Down Expand Up @@ -1165,7 +1165,7 @@ function ReadableStreamDefaultControllerCallPullIfNeeded(controller) {
}
}
)
.catch(e => rethrowAssertionErrorRejection(e));
.catch(rethrowAssertionErrorRejection);

return undefined;
}
Expand Down Expand Up @@ -1364,7 +1364,7 @@ class ReadableByteStreamController {
}
}
)
.catch(e => rethrowAssertionErrorRejection(e));
.catch(rethrowAssertionErrorRejection);
}

get byobRequest() {
Expand Down Expand Up @@ -1571,7 +1571,7 @@ function ReadableByteStreamControllerCallPullIfNeeded(controller) {
}
}
)
.catch(e => rethrowAssertionErrorRejection(e));
.catch(rethrowAssertionErrorRejection);

return undefined;
}
Expand Down
7 changes: 4 additions & 3 deletions reference-implementation/lib/writable-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,14 +578,15 @@ class WritableStreamDefaultController {
const startResult = InvokeOrNoop(underlyingSink, 'start', [this]);
Promise.resolve(startResult).then(
() => {
throw new assert.AssertionError('ss');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to commit this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Removed

controller._started = true;
WritableStreamDefaultControllerAdvanceQueueIfNeeded(controller);
},
r => {
WritableStreamDefaultControllerErrorIfNeeded(controller, r);
}
)
.catch(e => rethrowAssertionErrorRejection(e));
.catch(rethrowAssertionErrorRejection);
}

error(e) {
Expand Down Expand Up @@ -726,7 +727,7 @@ function WritableStreamDefaultControllerProcessClose(controller) {
WritableStreamDefaultControllerErrorIfNeeded(controller, r);
}
)
.catch(e => rethrowAssertionErrorRejection(e));
.catch(rethrowAssertionErrorRejection);
}

function WritableStreamDefaultControllerProcessWrite(controller, chunk) {
Expand Down Expand Up @@ -756,7 +757,7 @@ function WritableStreamDefaultControllerProcessWrite(controller, chunk) {
WritableStreamDefaultControllerErrorIfNeeded(controller, r);
}
)
.catch(e => rethrowAssertionErrorRejection(e));
.catch(rethrowAssertionErrorRejection);
}

function WritableStreamDefaultControllerUpdateBackpressure(controller) {
Expand Down