Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WebIDL definition(s) to use new mixin syntax #53

Closed
1 task
tobie opened this issue Nov 3, 2017 · 0 comments · Fixed by web-platform-tests/wpt#8702 or #54
Closed
1 task

Update WebIDL definition(s) to use new mixin syntax #53

tobie opened this issue Nov 3, 2017 · 0 comments · Fixed by web-platform-tests/wpt#8702 or #54

Comments

@tobie
Copy link

tobie commented Nov 3, 2017

Hi all!

WebIDL recently introduced dedicated syntax for mixins.

This syntax replaces the [NoInterfaceObject] extended attribute and implements statement which have been deprecated (except for a few legacy uses cases explicitely mentioned in the spec).

You can read more about it here.

In most cases, the changes should be relatively straightforward. The now deprecated:

interface Foo { };

[NoInterfaceObject]  // (Mostly) DEPRECATED
interface Bar { };
Foo implementes Bar; // DEPRECATED

should just be rewritten as:

interface Foo { };

interface mixin Bar { };
Foo includes Bar;

Additonaly, a section on when to use partials and mixins has been added to the spec. It's short and might be worth a read.

It seems the following interfaces in this spec are impacted by this change:

  • NavigatorStorage

We're sorry for the inconvenience this causes, but our hope is that this ultimately makes things simpler and clearer for everybody.

As always, please feel free to reach out if you have any questions.

Thanks!

Tracked in: whatwg/webidl#472 | Original pull-request: whatwg/webidl#433
@tobie tobie mentioned this issue Nov 3, 2017
Closed
4 tasks
romandev added a commit to romandev/storage that referenced this issue Dec 15, 2017
@romandev
Use interface mixins instead of [NoInterfaceObject]
14a891c 
WebIDL recently introduced dedicated syntax for mixins[1]. So, we can
replace `[NoInterfaceObject]` and `implements` with `interface mixin` and
`includes`.

This following interface is impacted by this change:
  - NavigatorStorage

This fixes whatwg#53 issue.

[1] whatwg/webidl@45e8173
This was referenced Dec 15, 2017
Merged
Merged
annevk pushed a commit to web-platform-tests/wpt that referenced this issue Dec 18, 2017
@romandev @annevk
Use new IDL mixin syntax in storage/
4005fa6 
This helps with whatwg/storage#53.
romandev added a commit to romandev/storage that referenced this issue Dec 18, 2017
@romandev
Use interface mixins instead of [NoInterfaceObject]
9e79239 
WebIDL recently introduced dedicated syntax for mixins[1]. So, we can
replace `[NoInterfaceObject]` and `implements` with `interface mixin` and
`includes`.

This following interface is impacted by this change:
  - NavigatorStorage

This fixes whatwg#53 issue.

[1] whatwg/webidl@45e8173
@annevk annevk reopened this Dec 18, 2017
annevk pushed a commit that referenced this issue Dec 23, 2017
@romandev @annevk
Use interface mixins instead of [NoInterfaceObject]
37030a2 
Turn NavigatorStorage into an interface mixin.

Tests: web-platform-tests/wpt#8702.

Fixes #53.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@tobie @annevk