Add WebSockets Standard #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/meta#202. Also fixes db.py to work on environments where the default encoding is not UTF-8, i.e., on Windows.
|
DNS propagation works; this is ready to merge. |
annevk
approved these changes
Dec 1, 2021
| @@ -96,7 +96,7 @@ def main(): | |||
| if command not in ["validate", "normalize"]: | |||
| usage() | |||
| else: | |||
| input = open("db.json", "r").read() | |||
| input = open("db.json", "r", encoding="utf-8").read() | |||
There was a problem hiding this comment.
Nit: shouldn't line 18 be changed as well then?
There was a problem hiding this comment.
Yeah, I guess I just didn't test that codepath. Will do.
|
Post-merge LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/meta#202.
Also fixes db.py to work on environments where the default encoding is not UTF-8, i.e., on Windows.
I chose 3,9 as the review draft schedule as that seems to be the new time we're lumping things at (for Web IDL and TestUtils).
Do not merge quite yet; the DNS propagation seems to be still in progress, so https://websockets.spec.whatwg.org does not work at the moment.
Also remember we need to re-deploy participate.whatwg.org manually per #171.