Get rid of entry settings object usage #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
requested changes
Apr 22, 2021
notifications.bs
Outdated
| @@ -718,7 +722,7 @@ constructor steps are: | |||
| <h3 id=static-members>Static members</h3> | |||
|
|
|||
| <p>The static <dfn attribute for=Notification><code>permission</code></dfn> getter steps are to | |||
| return the <a>permission</a> for the <a>entry settings object</a>'s | |||
| return the <a>permission</a> for <a>this</a>'s <a>relevant settings object</a>'s | |||
There was a problem hiding this comment.
This is static so it doesn't work. You want the <a>current settings object</a>.
There was a problem hiding this comment.
Hmm this probably is preexisting in requestPermission() somehow.
There was a problem hiding this comment.
I fixed both, thanks for spotting that!
Use the relevant settings object instead. Fixes #86.
|
New commit message: |
domenic
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the relevant settings object instead.
Fixes #86.
(Note that this builds upon #167.)
Preview | Diff