Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base URL instead of URL for links #9236

Merged
merged 2 commits into from
May 2, 2023
Merged

Use base URL instead of URL for links #9236

merged 2 commits into from
May 2, 2023

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Apr 30, 2023

Closes #8330

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • MDN issue is filed: …

(See WHATWG Working Mode: Changes for more details.)


/semantics.html ( diff )

@domenic
Copy link
Member

domenic commented May 1, 2023

Thanks! Can you do "process link headers" too for consistency? I don't think that one would have any normative impacts.

Also, bonus points for some tests (or finding existing tests).

@noamr
Copy link
Contributor Author

noamr commented May 1, 2023

Thanks! Can you do "process link headers" too for consistency? I don't think that one would have any normative impacts.

Also, bonus points for some tests (or finding existing tests).

Done.
To clarify, testing this would mean using the base element and seeing that preloads etc use that for relatives URLs?

@domenic
Copy link
Member

domenic commented May 2, 2023

To clarify, testing this would mean using the base element and seeing that preloads etc use that for relatives URLs?

Exactly.

@domenic domenic merged commit b6d8428 into whatwg:main May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

<link> base URL should use document's base URL, not document's URL
2 participants