Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noscript tag to spec's list for optional tag section. #8241

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Add noscript tag to spec's list for optional tag section. #8241

merged 4 commits into from
Sep 15, 2022

Conversation

tashasyarifah
Copy link
Contributor

@tashasyarifah tashasyarifah commented Aug 31, 2022 •
edited by pr-preview bot
Loading

Any review would be awesome. Thank you!

/syntax.html ( diff )

@domenic domenic requested a review from zcorpan September 5, 2022 02:59
zcorpan
zcorpan approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the lines should be wrapped at 100 cols.

Thanks!

source Outdated Show resolved Hide resolved
zcorpan
zcorpan reviewed Sep 12, 2022
View reviewed changes
source Outdated Show resolved Hide resolved
@zcorpan
Copy link
Member

zcorpan commented Sep 12, 2022

Looks good!

You (or your employer, if applicable) still need to sign the Participation Agreement before we can merge. See https://participate.whatwg.org/agreement-status?user=tashasyarifah&repo=html&pull=8241

Please let us know when it's signed so we can review and verify.

@tashasyarifah
Copy link
Contributor Author

I'm glad!

I've been struggling to sign the Participant Agreement. I contribute for individual purposes and am still a job seeker. I try to click signed as an individual but didn't work @zcorpan.

@zcorpan
Copy link
Member

zcorpan commented Sep 13, 2022

OK. In https://participate.whatwg.org/agreement under Signature you should expand "If signing as an Individual" and fill in the form and submit. If it doesn't work, please join https://whatwg.org/chat and ask for assistance.

@tashasyarifah
Copy link
Contributor Author

I don't see any form as you mentioned. The result that I got after I click submit was an invalid "entity-name" field. I'm confused.

Yeah, I'll ask for assistance in the chat. Hopefully, this issue can be solved.

Thank you for helping me @zcorpan.

@zcorpan zcorpan mentioned this pull request Sep 15, 2022
Open
@zcorpan
Copy link
Member

zcorpan commented Sep 15, 2022

All set! Thank you @tashasyarifah

@zcorpan zcorpan merged commit 6a77e6d into whatwg:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tashasyarifah @zcorpan