Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow hash method mismatch in comsuming preloads #7974

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Do not allow hash method mismatch in comsuming preloads #7974

merged 1 commit into from
Jun 3, 2022

Conversation

hiroshige-g
Copy link
Contributor

@hiroshige-g hiroshige-g commented Jun 1, 2022 •
edited by pr-preview bot
Loading

Fixes #7973.

(See WHATWG Working Mode: Changes for more details.)

/links.html ( diff )

domenic
domenic approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My read is that Firefox is OK with this change and both Chromium and Safari implement it. Can you confirm for Firefox, @annevk?

@annevk
Copy link
Member

annevk commented Jun 2, 2022

Yeah, this makes sense.

cc @mozfreddyb

@domenic domenic merged commit afcf6e5 into whatwg:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: resource hints (inc. preload)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hash method mismatch in comsuming preloads can allow response not matching consumer's integrity
3 participants
@hiroshige-g @annevk @domenic