Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site and obtain a site #5354

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Add site and obtain a site #5354

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abbf781
Add site and obtain a site
annevk Mar 13, 2020
38c5549
feedback
annevk Mar 23, 2020
48d84b8
thank you CI
annevk Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91744,11 +91744,13 @@ import "https://example.com/foo/../module2.mjs";</code></pre>
<p>A <dfn data-export="">scheme-and-registrable-domain</dfn> is a <span>tuple</span> of a <span
data-x="concept-url-scheme">scheme</span> and a <span data-x="concept-domain">domain</span>.</p>

<p>An <dfn data-export="">agent cluster key</dfn> is an <span>origin</span> or a
<p>A <dfn data-export="">site</dfn> is an <span data-x="concept-origin-opaque">opaque
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"either an" maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://dictionary.cambridge.org/grammar/british-grammar/either that's for two choices.

origin</span>, a <span data-x="concept-origin-tuple">tuple origin</span> whose <span
data-x="concept-origin-host">host</span>'s <span>registrable domain</span> is null, or a
<span>scheme-and-registrable-domain</span>.</p>

<p>To <dfn data-x="obtain-agent-cluster-key">obtain an agent cluster key</dfn>, given an origin
<var>origin</var>, run these steps:</p>
<p>To <dfn data-export="">obtain a site</dfn>, given an origin <var>origin</var>, run these
steps:</p>

<ol>
<li><p>If <var>origin</var> is an <span data-x="concept-origin-opaque">opaque origin</span>, then
Expand All @@ -91762,6 +91764,16 @@ import "https://example.com/foo/../module2.mjs";</code></pre>
domain</span>).</p></li>
</ol>

<p>An <dfn>agent cluster key</dfn> is a <span>site</span>.</p>

<p class="XXX"><a href="https://github.com/whatwg/html/pull/4734">whatwg/html #4734</a> is
expected to widen <span>agent cluster key</span> (but not <span>site</span>) to encompass all
<span data-x="concept-origin-tuple">tuple origins</span>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this one paragraph down so its clearer that it applies to both of the currently-trivial definitions? Not sure though.


<p>To <dfn data-x="obtain-agent-cluster-key">obtain an agent cluster key</dfn>, given an origin
<var>origin</var>, return the result of <span data-x="obtain a site">obtaining a site</span> with
<var>origin</var>.</p>

<p>To <dfn data-x="obtain-similar-origin-window-agent">obtain a similar-origin window agent</dfn>,
given an <span>origin</span> <var>origin</var> and <span>browsing context group</span>
<var>group</var>, run these steps:</p>
Expand Down