Editorial: use break in navigate algorithm rather than a variable #5277
Conversation
Also do not assume that all responses have a location URL (even though that would make more sense data-model-wise).
|
|
||
| <li> | ||
| <p>While <var>done</var> is false:</p> | ||
| <p>While true:</p> | ||
|
|
||
| <ol> | ||
| <li><p>Let <var>currentURL</var> be <var>response</var>'s <span |
There was a problem hiding this comment.
This also assumes that there's a location URL.
There was a problem hiding this comment.
It's fine in that case as there's a break when there's not.
There was a problem hiding this comment.
I don't understand. If response is non-null but response has no location URL, then the following steps:
Let currentURL be response's location URL, if response is not null, and request's current URL otherwise.
If reservedEnvironment is not null and currentURL's origin is not the same as reservedEnvironment's creation URL's origin, then:
will "crash" first when you try to access response's location URL, and then crash a second time when you try to access the non-existent location URL's origin.
There was a problem hiding this comment.
How can you get there with a response that has no location URL though?
There was a problem hiding this comment.
I see. However, note that one has to look down to step 7.4 and up to step 1 to figure that out. Perhaps add an assert beforehand?
There was a problem hiding this comment.
Let's just leave it until the Fetch thing is fixed?
|
The Fetch issue is whatwg/fetch#958 and I might do it I suppose, but I was hoping someone would pick it up as part of learning how to do things. |
Also do not assume that all responses have a location URL (even though that would make more sense data-model-wise).
/browsing-the-web.html ( diff )