Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass a request, rather than URL, to Navigate algorithm #3642

Merged
merged 7 commits into from
Apr 26, 2018
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -83073,21 +83073,31 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
<ol>

<li>
<p>If <var>entry</var> no longer holds a <code>Document</code> object, then run the following
substeps:</p>

<ol>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this newline.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<li><p>Let <var>request</var> be a new <span data-x="concept-request">request</span> whose
<span data-x="concept-request-url">url</span> is <var>entry</var>'s <span>URL</span>.</p></li>

<p>If <var>entry</var> no longer holds a <code>Document</code> object, then
<span>navigate</span><!--DONAV history traversal after eviction--> the <span>browsing
context</span> to <var>entry</var>'s <span>URL</span> to perform an <span>entry update</span> of
<var>entry</var>, and return. The "<span>navigate</span>" algorithm reinvokes this
"traverse" algorithm to complete the traversal, at which point there <em>is</em> a
<code>Document</code> object and so this step gets skipped. The navigation must be done using
the same <span>source browsing context</span> as was used the first time <var>entry</var> was
created. (This can never happen with <span>replacement enabled</span>.)</p>

<p class="note">If the resource was obtained using a non-idempotent action, for example a POST
form submission, or if the resource is no longer available, for example because the computer is
now offline and the page wasn't cached, navigating to it again might not be possible. In this
case, the navigation will result in a different page than previously; for example, it might be
an error message explaining the problem or offering to resubmit the form.</p>
<li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"And return" was really easy to miss here since there's a sentence and two notes after it. I'd suggest making it step 1.3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

<p><span>Navigate</span><!--DONAV history traversal after eviction--> the <span>browsing
context</span> to <var>request</var> to perform an <span>entry update</span> of
<var>entry</var>. The "<span>navigate</span>" algorithm reinvokes this "traverse" algorithm
to complete the traversal, at which point there <em>is</em> a <code>Document</code> object and
so this step gets skipped. The navigation must be done using the same <span>source browsing
context</span> as was used the first time <var>entry</var> was created. (This can never happen
with <span>replacement enabled</span>.)</p>

<p class="note">If the resource was obtained using a non-idempotent action, for example a POST
form submission, or if the resource is no longer available, for example because the computer
is now offline and the page wasn't cached, navigating to it again might not be possible. In
this case, the navigation will result in a different page than previously; for example, it
might be an error message explaining the problem or offering to resubmit the form.</p>
</li>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

</ol>

</li>

Expand Down