Ensure there is an active script while running JS jobs #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyGu
reviewed
Oct 27, 2017
source
Outdated
|
|
||
| <p class="note">This affects the <span>active script</span> while the job runs, in cases like | ||
| <code data-x="">Promise.resolve("...").then(eval)</code> where there would otherwise be no | ||
| active script since <code data-x="">eval</code> is a built-in function that does not original |
|
This appears to be correct for fixing tc39/ecma262#871 in HTML, but it could be that I'm missing some HTML-specific details, because I simply don't know the HTML spec that well. 😄 And I'm still wondering if calling |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 17, 2017
domenic
force-pushed
the
enqueuejob-script
branch
from
08cfce5 to
6261512
Compare
|
Tests are up. This is ready for review/merging. |
sideshowbarker
approved these changes
Nov 17, 2017
|
It seems this includes a commit that shouldn't be here. |
annevk
approved these changes
Nov 17, 2017
source
Outdated
| <li><p><span>Prepare to run a callback</span> with <var>incumbent settings</var>.</p></li> | ||
| <p class="note">This affects the <span>active script</span> while the job runs, in cases like | ||
| <code data-x="">Promise.resolve("...").then(eval)</code> where there would otherwise be no | ||
| active script since <code data-x="">eval</code> is a built-in function that does not originate |
"Fixes" tc39/ecma262#871, at least for HTML, given that we have our own version of EnqueueJob. Important for #3117.
domenic
force-pushed
the
enqueuejob-script
branch
from
6261512 to
42a1bef
Compare
jgraham
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 21, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 30, 2018
…ise jobs, a=testonly Automatic update from web-platform-testsTest active script, via import(), in promise jobs Follows whatwg/html#3163. -- wpt-commits: 1c3621705bdd047fde1e4a2a165c49ec837ffa1c wpt-pr: 8287
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…ise jobs, a=testonly Automatic update from web-platform-testsTest active script, via import(), in promise jobs Follows whatwg/html#3163. -- wpt-commits: 1c3621705bdd047fde1e4a2a165c49ec837ffa1c wpt-pr: 8287 UltraBlame original commit: 89d303876a7e1b2b43d099822477b7f80333b71b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ise jobs, a=testonly Automatic update from web-platform-testsTest active script, via import(), in promise jobs Follows whatwg/html#3163. -- wpt-commits: 1c3621705bdd047fde1e4a2a165c49ec837ffa1c wpt-pr: 8287 UltraBlame original commit: 89d303876a7e1b2b43d099822477b7f80333b71b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…ise jobs, a=testonly Automatic update from web-platform-testsTest active script, via import(), in promise jobs Follows whatwg/html#3163. -- wpt-commits: 1c3621705bdd047fde1e4a2a165c49ec837ffa1c wpt-pr: 8287 UltraBlame original commit: 89d303876a7e1b2b43d099822477b7f80333b71b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fixes" tc39/ecma262#871, at least for HTML, given that we have our own version of EnqueueJob. Important for #3117.
People who may be interested in reviewing this: @anba @bzbarsky @nyaxt. Alternately I'm happy with just editorial review as this stuff is pretty subtle.
Tests: web-platform-tests/wpt#8287