Editorial: let code point and co be defined by Infra #2471
Conversation
See whatwg/infra#6 for context.
source
Outdated
| @@ -2390,6 +2365,11 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
| <p>The following terms are defined in the WHATWG Infra standard: <ref spec=INFRA></p> | |||
|
|
|||
| <ul class="brief"> | |||
| <li><dfn data-x-href="https://infra.spec.whatwg.org/#code-point">code point</dfn> and its synonym | |||
| <dfn data-x-href="https://infra.spec.whatwg.org/#code-point">character</dfn></li> | |||
There was a problem hiding this comment.
Nit: I believe we line up the <dfns in similar blocks
There was a problem hiding this comment.
This is how it's lined up later on in this <ul>...
There was a problem hiding this comment.
It looks to be inconsistent. Position variable is not lined up, but the rest of them are.
source
Outdated
| @@ -2438,7 +2418,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
|
|
|||
| <dd> | |||
|
|
|||
| <p>The Unicode character set is used to represent textual data, and the WHATWG Encoding standard | |||
| <p>The Unicode Standard is used to represent textual data, and the WHATWG Encoding standard | |||
There was a problem hiding this comment.
I'm not sure the standard is used to represent the data. A character set seems more likely to be used to represent data than a standard
| <li><p>Replace any characters in <var>input</var> that have a Unicode code point greater | ||
| than U+FFFF (i.e. any characters that are not in the basic multilingual plane) with the | ||
| two-character string "<code data-x="">00</code>".</p></li> | ||
| <li><p>Replace any characters in <var>input</var> that have a code point greater than U+FFFF |
There was a problem hiding this comment.
Is the idea to not introduce new links? Seems OK, but maybe a missed opportunity.
source
Outdated
| appropriate.</p> | ||
| <p>An image should not be used if characters would serve an identical purpose. Only when the text | ||
| cannot be directly represented using text, e.g., because of decorations or because the character | ||
| is not in the Unicode Standard (as in the case of gaiji), would an image be appropriate.</p> |
There was a problem hiding this comment.
Again character set seems more accurate here.
source
Outdated
| @@ -72016,14 +71995,14 @@ END:VCARD</pre> | |||
|
|
|||
| <li> | |||
|
|
|||
| <p>If and while <var>line</var> is longer than <var>maximum length</var> | |||
| Unicode code points long, run the following substeps:</p> | |||
| <p>If and while <var>line</var> is longer than <var>maximum length</var> code points long:</p> | |||
There was a problem hiding this comment.
You could link longer/long to string length here (as opposed to JavaScript string length)
There was a problem hiding this comment.
Why do we say "If and while" rather than just "While"?
| U+003B SEMICOLON character (;).</dd> | ||
| <span>ASCII digits</span>, representing a base-ten integer that corresponds to a code point that | ||
| is allowed according to the definition below. The digits must then be followed by a U+003B | ||
| SEMICOLON character (;).</dd> |
There was a problem hiding this comment.
In general I'd like to replace "character" by "code point" when possible, but I realize I'm just piling work onto this PR, so feel free to ignore this suggestion.
There was a problem hiding this comment.
A dedicated commit might be better for that. Happy to make one though.
| @@ -100478,7 +100454,8 @@ dictionary <dfn>StorageEventInit</dfn> : <span>EventInit</span> { | |||
|
|
|||
| <dl class="switch"> | |||
|
|
|||
| <dt>A sequence of bytes starting with: 0x3C 0x21 0x2D 0x2D (ASCII '<!--')</dt> | |||
| <dt>A sequence of bytes starting with: 0x3C 0x21 0x2D 0x2D (`<code | |||
| data-x=""><!--</code>`)</dt> | |||
There was a problem hiding this comment.
Nice to fix this into using byte sequence notation
| <dd>Append the Unicode character with code point <span data-x=""><var>b</var>+0x20</span> to <var>attribute name</var> (where <var>b</var> | ||
| is the value of the byte at <var>position</var>). (This converts the input to | ||
| lowercase.)</dd> | ||
| <dd>Append the code point <span data-x=""><var>b</var>+0x20</span> to <var>attribute name</var> |
There was a problem hiding this comment.
Any idea why this has a span data-x=""?
| @@ -100879,9 +100861,9 @@ dictionary <dfn>StorageEventInit</dfn> : <span>EventInit</span> { | |||
| U+4FFFF, U+5FFFE, U+5FFFF, U+6FFFE, U+6FFFF, U+7FFFE, U+7FFFF, U+8FFFE, U+8FFFF, U+9FFFE, U+9FFFF, | |||
| U+AFFFE, U+AFFFF, U+BFFFE, U+BFFFF, U+CFFFE, U+CFFFF, U+DFFFE, U+DFFFF, U+EFFFE, U+EFFFF, U+FFFFE, | |||
| U+FFFFF, U+10FFFE, and U+10FFFF are <span data-x="parse error">parse errors</span>. These are all | |||
| <span>control characters</span> or permanently undefined Unicode characters (noncharacters).</p> | |||
| <span>control characters</span> or permanently undefined characters (noncharacters).</p> | |||
There was a problem hiding this comment.
This "permanently undefined characters (noncharacters)" concept keeps coming up and probably deserves a term defined in Infra.
There was a problem hiding this comment.
Opened an issue. Probably best done as cleanup afterward.
|
There are a lot of hits for |
|
I think |
See whatwg/infra#6 for context.