Return null when window.open() is popup blocked #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed No web-platform-test because according to @jgraham there's no way currently to test with the popup blocker enabled. Filed web-platform-tests/wpt#3867 |
zcorpan
reviewed
Oct 4, 2016
| @@ -78673,7 +78673,7 @@ callback <dfn>FrameRequestCallback</dfn> = void (<span>DOMHighResTimeStamp</span | |||
| <p>Otherwise, apply <span>the rules for choosing a browsing context given a browsing context | |||
| name</span> using <var>target</var> as the name and <var>source browsing context</var> as the | |||
| context in which the algorithm is executed. If this results in there not being a chosen browsing | |||
| context, then abort these steps. Otherwise, let <var>target browsing context</var> be the | |||
| context, then return null. Otherwise, let <var>target browsing context</var> be the | |||
There was a problem hiding this comment.
Should this say "return null and abort these steps", or have we stopped using such phrasing in HTML?
There was a problem hiding this comment.
We are slowly moving away from it.
kisg
pushed a commit
to paul99/webkit-mips
that referenced
this pull request
Oct 4, 2016
https://bugs.webkit.org/show_bug.cgi?id=162897 Reviewed by Michael Catanzaro. Source/WebCore: The return value of window.open() when the popup is blocked should be null: - whatwg/html#1854 - whatwg/html#1851 Firefox / Edge return null. No new tests, rebaselined existing tests. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): LayoutTests: Rebaseline existing tests to reflect behavior change. * fast/events/popup-blocked-from-fake-button-click-expected.txt: * fast/events/popup-blocked-from-fake-button-click.html: * fast/events/popup-blocked-from-fake-focus-expected.txt: * fast/events/popup-blocked-from-fake-focus.html: * fast/events/popup-blocked-from-fake-user-gesture-expected.txt: * fast/events/popup-blocked-from-fake-user-gesture.html: * fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt: * fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html: * fast/events/popup-blocking-timers3-expected.txt: * fast/events/popup-blocking-timers3.html: * fast/events/popup-blocking-timers4-expected.txt: * fast/events/popup-blocking-timers4.html: * fast/events/popup-blocking-timers6-expected.txt: * fast/events/popup-blocking-timers6.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@206777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1848, fixes #1851.