-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional accessibility guidance for popover #8714
Comments
Should we say where authors can find examples of this? I think we specifically mean setting the role, perhaps we should say that. We could consider listing an incomplete set of commonly used roles in popups, such as diallog, group, listbox, etc. |
The PR was reverted and reopened, you can see the latest version here: https://whatpr.org/html/8717/popover.html
Domenic knows best but I suppose that putting the "The popover attribute is a global attribute to allow authors flexibility" paragraph after the "All HTML elements may have the popover content attribute set" paragraph sounds good, and the "To help ensure a popover will be programmatically exposed" paragraph could go after the "The popover target attributes allow certain types of buttons" paragraph.
If you could do that in your followup PR that would be awesome! |
appreciate the responses. will look to do that asap |
closes whatwg#8714 - adds two notes for the popover attribute and its target attributes to provide author guidance to ensure best accessibility practices for their popovers. - modifies the popover examples to ensure the popover follows the triggering element in the DOM reading order. This is NOT a requirement, but it will often be the way it SHOULD be done. though, i am not sure we want to make that a proper ‘should’ - hence it’s being added as a note.
Now that #8221 has been merged, I've drafted the two following notes (edits welcome) that I think need to be included for popover and the popover target attributes sections:
for
popover
:for the popover target attributes section:
in addition to the above note, I'd also want to adjust the examples to also reflect this guidance. The popover ideally would come after the button element. Additionally, at least one of the examples would also use a non-generic element (a list or an article, for example). Maybe one of the examples could also have an ARIA role to match the guidance of the note. If we want to leave one of the examples as is, I'd be happy to include another to demonstrate this, instead.
I'm happy to make the PR for this, but would just request any preferences as to where these notes (particularly the one i mentioned as being for the
popover
attribute) would best fit in the flow of each section's content.cc @mfreed7, @josepharhar, @aleventhal, @domenic
Thanks
The text was updated successfully, but these errors were encountered: