Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The conditions when a script element is implicitly potentially render-blocking are wrong #7893

Closed
xiaochengh opened this issue May 6, 2022 · 0 comments · Fixed by #7894
Closed

The conditions when a script element is implicitly potentially render-blocking are wrong #7893

xiaochengh opened this issue May 6, 2022 · 0 comments · Fixed by #7894

Comments

@xiaochengh
Copy link
Contributor

xiaochengh commented May 6, 2022 •
edited
Loading

#7857 defined the following:

A script element is implicitly potentially render-blocking if the element's script's type is set and is equal to "classic", and the element is "parser-inserted".

This is obviously wrong. It should be parser-inserted classic script without async or defer attributes.

Question: should we consider dynamically inserted script with async set to false?
Edit: we shouldn't. I've tested this test case in Chrome, Safari and Firefox, and none of them blocks rendering on the script.

@domenic
@xiaochengh xiaochengh mentioned this issue May 6, 2022
Merged
3 tasks
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 12, 2022
@xiaochengh @chromium-wpt-export-bot
Add a WPT for when a <script> is not implicitly potentially render-bl…
bc3ecae 
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Merged
aarongable pushed a commit to chromium/chromium that referenced this issue May 12, 2022
@xiaochengh
Add a WPT for when a <script> is not implicitly potentially render-bl…
0c63e93 
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1002737}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 12, 2022
@xiaochengh @chromium-wpt-export-bot
Add a WPT for when a <script> is not implicitly potentially render-bl…
c19b98d 
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1002737}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue May 12, 2022
@xiaochengh @chromium-wpt-export-bot
Add a WPT for when a <script> is not implicitly potentially render-bl…
7f4089c 
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1002737}
zcorpan pushed a commit that referenced this issue May 16, 2022
@xiaochengh
Fix when a script element is implicitly potentially render-blocking
76f47d3 
Fixes #7893, which is a bug introduced by #7857.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 18, 2022
@xiaochengh @moz-wptsync-bot
Bug 1768981 [wpt PR 34038] - Add a WPT for when a <script> is not imp…
23b8dd2 
…licitly potentially render-blocking, a=testonly

Automatic update from web-platform-tests
Add a WPT for when a <script> is not implicitly potentially render-blocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1002737}

--

wpt-commits: 7f4089c1f0ba37dc51fb3a220f8719ff98863374
wpt-pr: 34038
jamienicol pushed a commit to jamienicol/gecko that referenced this issue May 25, 2022
@xiaochengh @moz-wptsync-bot
Bug 1768981 [wpt PR 34038] - Add a WPT for when a <script> is not imp…
953ea49 
…licitly potentially render-blocking, a=testonly

Automatic update from web-platform-tests
Add a WPT for when a <script> is not implicitly potentially render-blocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1002737}

--

wpt-commits: 7f4089c1f0ba37dc51fb3a220f8719ff98863374
wpt-pr: 34038
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@xiaochengh @mfreed7
Fix when a script element is implicitly potentially render-blocking
185208a 
Fixes whatwg#7893, which is a bug introduced by whatwg#7857.
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@xiaochengh @copybara-github
Add a WPT for when a <script> is not implicitly potentially render-bl…
32c6006 
…ocking

For whatwg/html#7894

Bug: 1271296
Bug: whatwg/html#7893
Change-Id: I95609738722122c96d65ccc588cbbd4c90ce67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3643218
Auto-Submit: Xiaocheng Hu <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1002737}
NOKEYCHECK=True
GitOrigin-RevId: 0c63e935d875f7bbb2270333f54c9c698a8a0c79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix when a script element is implicitly potentially render-blocking xiaochengh/html
1 participant
@xiaochengh