Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio button activation behavior is not quite right #3239

Closed
domenic opened this issue Nov 19, 2017 · 1 comment
Closed

Radio button activation behavior is not quite right #3239

domenic opened this issue Nov 19, 2017 · 1 comment

Comments

@domenic
Copy link
Member

domenic commented Nov 19, 2017

https://html.spec.whatwg.org/#radio-button-state-(type=radio)

The input activation behavior is to fire an event named input at the element, with the bubbles attribute initialized to true, and then fire an event named change at the element, with the bubbles attribute initialized to true.

However, this test shows that's not the case:

https://jsbin.com/nunawax/1/edit?html,output

Via @liqwid in jsdom/jsdom#2037 (comment)

@liqwid's fix in jsdom was to save the checkedness of the radio button before the legacy-pre-activation behavior steps run, and if that was checked, skip the (input) activation behavior.

@domenic
Copy link
Member Author

domenic commented Feb 28, 2021

Forward-duping to #5000 which was fixed.

@domenic domenic closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant