Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final recursive step of fullscreen element ready check is redundant #50

Closed
foolip opened this issue Sep 13, 2016 · 0 comments
Closed

Final recursive step of fullscreen element ready check is redundant #50

foolip opened this issue Sep 13, 2016 · 0 comments

Comments

@foolip
Copy link
Member

foolip commented Sep 13, 2016

Currently the fullscreen element ready check is:

  • element's namespace is the HTML namespace or element is an SVG svg or MathML math element.
  • element is in a document.
  • element's node document is allowed to use the feature indicated by attribute name allowfullscreen.
  • element's node document's browsing context either has a browsing context container and the fullscreen element ready check returns true for element's node document's browsing context's browsing context container, or it has no browsing context container.

The final point is redundant, as it's guaranteed to be true by the previous two. The "allowed to use check" guarantees that if this isn't the top-level browsing context, then it's connected to it via iframes, which must be in documents, as removing an iframe discards its browsing context.

Will PR.
foolip added a commit that referenced this issue Sep 14, 2016
@foolip
Remove redundant recursive step of fullscreen element ready check
50b8061 
HTML's "allowed to use" only returns true if the document is in the
top-level browsing context, or if it's connected to it via any number of
iframes, all of which must be in a document to have nested browsing
contexts at all, so this final condition would always be true.

Fixes #50.
@foolip foolip mentioned this issue Sep 14, 2016
Merged
foolip added a commit that referenced this issue Sep 15, 2016
@foolip
Remove redundant recursive step of fullscreen element ready check
2f71e0b 
HTML's "allowed to use" only returns true if the document is in the
top-level browsing context, or if it's connected to it via any number of
iframes, all of which must be in a document to have nested browsing
contexts at all, so this final condition would always be true.

Fixes #50.
foolip added a commit that referenced this issue Sep 15, 2016
@foolip
Remove redundant recursive step of fullscreen element ready check (#52)
484ca40 
HTML's "allowed to use" only returns true if the document is in the
top-level browsing context, or if it's connected to it via any number of
iframes, all of which must be in a document to have nested browsing
contexts at all, so this final condition would always be true.

Fixes #50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@foolip