-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define fullscreen in terms of feature policy #106
Comments
This change defines Fullscreen as a policy-controlled feature, referencing the feature policy spec. It makes use of the currently- monkey-patched "Allowed to use" algorithm in HTML to allow the document's policy to control whether an element is permitted to go fullscreen. Fixes: whatwg#106
I don't understand how 4 in https://wicg.github.io/feature-policy/#integration-with-html works. How many implementers have committed to feature policy? |
The idea is that:
(If FP controls the features completely, then we'd probably want to get rid of step 3 as well, since FP will also handle that case) I've filed w3c/webappsec-permissions-policy#95 to track actually making it clearer.
Chrome, certainly -- I don't know that there is any public commitment from other implementers. That does raise the question of whether it's better to include language for browsers which don't support FP, or to let PRs like this sit until there is general support. I don't know what the right answer to that is, though. |
WICG/gesture-delegation#13 suggests Safari might be on board with Feature Policy. Is that correct @othermaciej? Haven't seen public signals from Mozilla yet. I'd like at least two implementors on board before integrating this everywhere. It'd be rather costly to revert it all. As for that new algorithm, I don't think that works as-is. It doesn't deal with "allowattribute flag" for instance or the referenced issue about |
We don't have a specific implementation plan or timeline yet, but I think we generally like the idea. |
This change defines Fullscreen as a policy-controlled feature, referencing the feature policy spec. It makes use of the currently- monkey-patched "Allowed to use" algorithm in HTML to allow the document's policy to control whether an element is permitted to go fullscreen. Fixes: whatwg#106
This change defines Fullscreen as a policy-controlled feature, referencing the feature policy spec. It makes use of the currently- monkey-patched "Allowed to use" algorithm in HTML to allow the document's policy to control whether an element is permitted to go fullscreen. Fixes: #106 Tests: #107 (comment)
https://wicg.github.io/feature-policy informally declares Fullscreen to be a policy-controlled feature (and Chrome currently implements it as such). I'm trying to work out what it would take to make that more formal.
Currently, I have:
I'm sure I'm missing something big still :)
The text was updated successfully, but these errors were encountered: