Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how Headers does not support Set-Cookie #714

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Clarify how Headers does not support Set-Cookie #714

merged 1 commit into from
Jul 23, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 19, 2018 •
edited by pr-preview bot
Loading

Fixes #345.

Preview | Diff

@annevk annevk requested a review from mnot April 19, 2018 14:26
@annevk annevk mentioned this pull request Apr 19, 2018
Closed
mnot
mnot approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@mnot mnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, as long as it's OK to lose fidelity regarding the difference between two header values on a single line vs. in two header instances.

@annevk annevk merged commit 7ab665e into master Jul 23, 2018
@annevk annevk deleted the annevk/headers-and-set-cookie branch July 23, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnot mnot mnot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @mnot