Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a render-blocking boolean flag to the request concept #1432

Merged
merged 2 commits into from
May 24, 2022
Merged

Add a render-blocking boolean flag to the request concept #1432

merged 2 commits into from
May 24, 2022

Conversation

xiaochengh
Copy link
Contributor

@xiaochengh xiaochengh commented May 2, 2022 •
edited by pr-preview bot
Loading

Fixes #1433. The HTML-side counterpart is whatwg/html#7885.

This is also a minor follow-up of whatwg/html#7474.

(See WHATWG Working Mode: Changes for more details.)

Preview | Diff

@xiaochengh xiaochengh mentioned this pull request May 3, 2022
Closed
@xiaochengh xiaochengh changed the title Add a render-blocking boolean flag to request Add a render-blocking boolean flag to the request concept May 4, 2022
@xiaochengh xiaochengh force-pushed the render-blocking-behavior branch from 2f45e67 to 74c8982 Compare May 4, 2022 19:47
@xiaochengh xiaochengh mentioned this pull request May 4, 2022
Merged
3 tasks
@xiaochengh xiaochengh marked this pull request as ready for review May 4, 2022 20:21
@xiaochengh
Copy link
Contributor Author

@annevk @yoavweiss PTAL

annevk
annevk reviewed May 18, 2022
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me modulo some nits.

fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
xiaochengh
xiaochengh commented May 23, 2022
View reviewed changes
Copy link
Contributor Author

@xiaochengh xiaochengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing!

fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
fetch.bs Outdated Show resolved Hide resolved
annevk
annevk approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@annevk annevk merged commit 80c38ca into whatwg:main May 24, 2022
@xiaochengh xiaochengh deleted the render-blocking-behavior branch May 24, 2022 16:34
aarongable pushed a commit to chromium/chromium that referenced this pull request May 24, 2022
@xiaochengh
Bump fetch priority to at least kHigh if resource is render-blocking
5d88188 
This patch follows from the fetch spec revision:

whatwg/fetch#1432

Bug: 1271296
Change-Id: I3f56e921e238a7e28774d5407a78d4df4f4145d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627294
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Patrick Meenan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1007082}
domenic pushed a commit to whatwg/html that referenced this pull request Jun 1, 2022
@xiaochengh
Set requests' render-blocking flag based on blocking="render"
a4ccf54 
See whatwg/fetch#1433 and whatwg/fetch#1432 for background.
mfreed7 pushed a commit to mfreed7/html that referenced this pull request Jun 3, 2022
@xiaochengh @mfreed7
Set requests' render-blocking flag based on blocking="render"
1b42f14 
See whatwg/fetch#1433 and whatwg/fetch#1432 for background.
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@xiaochengh @copybara-github
Bump fetch priority to at least kHigh if resource is render-blocking
e14d72a 
This patch follows from the fetch spec revision:

whatwg/fetch#1432

Bug: 1271296
Change-Id: I3f56e921e238a7e28774d5407a78d4df4f4145d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3627294
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Xiaocheng Hu <[email protected]>
Reviewed-by: Patrick Meenan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1007082}
NOKEYCHECK=True
GitOrigin-RevId: 5d88188b6b09aa1bb29b96177ab49a0d66a560c5
@xiaochengh xiaochengh mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: add a boolean flag render-blocking to the request concept
2 participants
@xiaochengh @annevk