ISO-2022-JP encoder: document an oddity #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point it does not seem worth it to require further implementation changes and risk compatibility issues, so instead document the quirk. Closes #115.
domenic
reviewed
Aug 30, 2018
encoding.bs
Outdated
| @@ -2650,6 +2650,15 @@ consumers of content generated with <a>GBK</a>'s <a for=/>encoder</a>. | |||
|
|
|||
| <h4 id=iso-2022-jp-encoder dfn export>ISO-2022-JP encoder</h4> | |||
|
|
|||
| <div class="note no-backref"> | |||
| <p>The <a>ISO-2022-JP encoder</a> is the only <a for=/>encoder</a> for which the concetenation of | |||
hsivonen
suggested changes
Aug 31, 2018
encoding.bs
Outdated
| @@ -2650,6 +2650,15 @@ consumers of content generated with <a>GBK</a>'s <a for=/>encoder</a>. | |||
|
|
|||
| <h4 id=iso-2022-jp-encoder dfn export>ISO-2022-JP encoder</h4> | |||
|
|
|||
| <div class="note no-backref"> | |||
| <p>The <a>ISO-2022-JP encoder</a> is the only <a for=/>encoder</a> for which the concatenation of | |||
| multiple outputs can result in an <a>error</a> when run through the <a>ISO-2022-JP decoder</a>. | |||
There was a problem hiding this comment.
I'd say "corresponding decoder" instead of "ISO-2022-JP decoder" to be pedantic about this being self-decode and not about decoding the output of other encoders with the ISO-2022-JP decoder. Other than that, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point it does not seem worth it to require further implementation changes and risk compatibility issues, so instead document the quirk.
Closes #115.
Preview | Diff