Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Event's cancelBubble attribute #383

Merged
merged 3 commits into from
Dec 19, 2016
Merged

Add Event's cancelBubble attribute #383

merged 3 commits into from
Dec 19, 2016

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 7, 2016

More delightful garbage from the past. Fixes #211.

annevk added 2 commits December 6, 2016 15:00
@annevk
Add Event's cancelBubble attribute
96c9eb4 
More delightful garbage from the past. Fixes #211.
@annevk
fixup
9c6181f
@annevk
Copy link
Member Author

annevk commented Dec 7, 2016

@cvrebert do you have tests for this already?

@cvrebert
Copy link
Member

cvrebert commented Dec 7, 2016

@annevk Yes. Though actual submission of them is blocked on the web-platform-tests equivalent of w3c/csswg-test#1091

cvrebert
cvrebert reviewed Dec 7, 2016
View reviewed changes
dom.bs
@@ -511,6 +511,7 @@ interface Event {
readonly attribute unsigned short eventPhase;

void stopPropagation();
attribute boolean cancelBubble; // historical
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the normal indentation for attributes without readonly. They are aligned with their readonly counterparts.

@annevk
Copy link
Member Author

annevk commented Dec 7, 2016

@cvrebert great, is there an issue on file for WPT to get such a LICENSE resource?

@cvrebert
Copy link
Member

cvrebert commented Dec 7, 2016

@annevk Just filed web-platform-tests/wpt#4295

@cvrebert
Copy link
Member

cvrebert commented Dec 8, 2016

The {{Event/cancelBubble}} attribute's setter must set context object's stop propagation flag if the given value is true, and unset it otherwise.

Erm, if we want to make it equivalent to stopPropagation (per the issue), then it shouldn't be possible to unset it, except via (re)initialization. So the setter shouldn't do anything if the value is not true.

@cvrebert
Copy link
Member

cvrebert commented Dec 8, 2016

Got the OK from Legal, so expect a testcases PR tonight.

@cvrebert
Copy link
Member

cvrebert commented Dec 9, 2016

Proposed tests: web-platform-tests/wpt#4304

@annevk
Copy link
Member Author

annevk commented Dec 9, 2016

Cool, guess we should wait and see if any browsers are comfortable restricting the semantics further as you suggested.

@annevk annevk mentioned this pull request Dec 19, 2016
Merged
annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 19, 2016
@cvrebert @annevk
Add tests for Event's cancelBubble
5d6f88b 
Discussion at whatwg/dom#211 and standard change at whatwg/dom#383.
@annevk annevk merged commit e8a9f67 into master Dec 19, 2016
@annevk annevk deleted the annevk/cancelbubble branch December 19, 2016 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvrebert cvrebert cvrebert left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @cvrebert