This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Add popups displaying specific alerts #1783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrund
suggested changes
Apr 14, 2020
There was a problem hiding this comment.
This is a good UX change, however there are a few styling issues I saw while testing it out.
The popover underflows the sidebar (and overflows the page even when the sidebar is closed.
In addition, an outline for the icon is shown when the popover is focused.
Similarly here, the popover is hidden by the tree-view.
ip1981
force-pushed
the
ip1981/1578-alert-popup
branch
from
46a90c6
to
907aba2
Compare
|
Removed outlines. Overflows seem a general problem as in https://github.com/whamcloud/integrated-manager-for-lustre/issues/1748. Looking. |
ip1981
force-pushed
the
ip1981/1578-alert-popup
branch
from
907aba2
to
e8e8646
Compare
|
I am going to split z-index parts to a separate PR. |
ip1981
force-pushed
the
ip1981/1578-alert-popup
branch
from
e8e8646
to
9a36cd0
Compare
Signed-off-by: Igor Pashev <[email protected]>
ip1981
force-pushed
the
ip1981/1578-alert-popup
branch
from
9a36cd0
to
61ed195
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1578.
Signed-off-by: Igor Pashev [email protected]
This change is