Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back end endpoints for MetaData #397

Merged
merged 16 commits into from
May 31, 2023
Merged

Back end endpoints for MetaData #397

merged 16 commits into from
May 31, 2023

Conversation

manuel-delvillar
Copy link
Contributor

@manuel-delvillar manuel-delvillar commented May 9, 2023 •
edited
Loading

Security

  • Add @EnableGlobalMethodSecurity to use @PreAuthorize
  • Use @PreAuthorize for security in controllers

Job Codes

Available for all authenticated users

  • Get all job codes with pagination
  • Get job code by ID

Available for admin role

  • Create one or more job codes
  • Update a job code
  • Delete a job code

Named References

Available for all authenticated users

  • Get all named references with pagination
  • Get named reference by ID

Available for admin role

  • Create one or more named references
  • Update a named reference
  • Delete a named reference

Some request contains a little logic to save and return data, but important changes are related to match with the "open api file" in PR #391

@manuel-delvillar manuel-delvillar added enhancement New feature or request WIP Working in progress labels May 9, 2023
@manuel-delvillar manuel-delvillar self-assigned this May 9, 2023
@manuel-delvillar manuel-delvillar requested a review from a team May 9, 2023 19:06
@manuel-delvillar manuel-delvillar marked this pull request as ready for review May 9, 2023 19:06
jchavez137
jchavez137 suggested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@jchavez137 jchavez137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, remove only the star imports and commented code in SecurityConfig

@JohnKallies
Copy link
Contributor

Is there any test coverage in this change?

@manuel-delvillar
Copy link
Contributor Author

@JohnKallies I am going to add some test for controller.

@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-284-back-end-endpoints-admin-screen branch 3 times, most recently from 2473005 to a1aff2b Compare May 17, 2023 22:14
@Corpratespaz Corpratespaz removed the WIP Working in progress label May 22, 2023
@Corpratespaz Corpratespaz changed the base branch from develop to feature/admin-screens May 22, 2023 18:51
@manuel-delvillar manuel-delvillar force-pushed the feature/OSMT-284-back-end-endpoints-admin-screen branch from 729686f to 95e7ba6 Compare May 31, 2023 21:51
@Corpratespaz Corpratespaz merged commit 9f4aea8 into feature/admin-screens May 31, 2023
@Corpratespaz Corpratespaz deleted the feature/OSMT-284-back-end-endpoints-admin-screen branch May 31, 2023 22:01
manuel-delvillar added a commit that referenced this pull request Jun 13, 2023
@manuel-delvillar
Back end endpoints for MetaData (#397)
7172d16 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
manuel-delvillar added a commit that referenced this pull request Jun 13, 2023
@manuel-delvillar
Back end endpoints for MetaData (#397)
9cd2094 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
manuel-delvillar added a commit that referenced this pull request Jun 28, 2023
@manuel-delvillar
Back end endpoints for MetaData (#397)
4bda877 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
@Corpratespaz Corpratespaz mentioned this pull request Jun 30, 2023
Draft
8 tasks
manuel-delvillar added a commit that referenced this pull request Jul 7, 2023
@manuel-delvillar
Back end endpoints for MetaData (#397)
64e1b74 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
manuel-delvillar added a commit that referenced this pull request Jul 11, 2023
@manuel-delvillar
Back end endpoints for MetaData (#397)
8c88286 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
manuel-delvillar added a commit that referenced this pull request Jul 11, 2023
@manuel-delvillar
Back end endpoints for MetaData (#397)
fdaf509 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
Corpratespaz pushed a commit that referenced this pull request Jul 12, 2023
@manuel-delvillar @Corpratespaz
Back end endpoints for MetaData (#397)
6c9eee6 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
manuel-delvillar added a commit that referenced this pull request Jul 18, 2023
@manuel-delvillar
Back end endpoints for MetaData (#397)
52261be 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
manuel-delvillar added a commit that referenced this pull request Jul 19, 2023
@manuel-delvillar
Back end endpoints for MetaData (#397)
056bb7d 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
jchavez137 pushed a commit that referenced this pull request Jul 19, 2023
@manuel-delvillar @jchavez137
Back end endpoints for MetaData (#397)
d4102ab 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
Corpratespaz pushed a commit that referenced this pull request Jul 25, 2023
@manuel-delvillar @Corpratespaz
Back end endpoints for MetaData (#397)
abf9f9e 
* Add paths for jobcodes

* Add paths for named references

* Enable EnableGlobalMethodSecurity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corpratespaz Corpratespaz Corpratespaz left review comments

@jchavez137 jchavez137 jchavez137 approved these changes

Assignees

@manuel-delvillar manuel-delvillar

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuel-delvillar @JohnKallies @Corpratespaz @jchavez137