Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to dekonize peptide into AA list #22

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Conversation

melihyilmaz
Copy link
Collaborator

Added option for detokenize to return peptide sequence as a list of amino acids rather than only in the string format. This was needed in the context of Casanovo for cases where multiple N-terminal modifications are predicted back to back (e.g. -17.027+42.011) and the downstream regex logic fails to differentiate these PTMs. Refer to below discussion for more details:
Noble-Lab/casanovo#87 (comment)

@melihyilmaz
Copy link
Collaborator Author

@wfondrie Should I add a unit test for detokenize or is failure due to something else?

@wfondrie
Copy link
Owner

wfondrie commented Nov 15, 2022

The above previous errors were due to a failure to upload test coverage to CodeCov, which hopefully I've fixed now 🤞

Should I add a unit test for ...

The answer to this question is always yes 😉

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Merging #22 (16b9098) into main (23683c0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files          19       19           
  Lines         854      854           
=======================================
  Hits          743      743           
  Misses        111      111           
Impacted Files Coverage Δ
depthcharge/components/transformers.py 98.16% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wfondrie
Copy link
Owner

Is there a good reason to every return a string? It seems like we should just make it always return a list. It seems easy enough for the user to join the string if they desire. 🤔

I'd ok with the breaking change for now, since I think Casanovo is currently the only dependent. What do you think @melihyilmaz and @bittremieux?

@bittremieux
Copy link
Collaborator

I concur.

@melihyilmaz
Copy link
Collaborator Author

melihyilmaz commented Nov 15, 2022

Makes sense we can only return a list, I added it as an option earlier to avoid breaking things down.

@wfondrie wfondrie merged commit 4837737 into main Nov 15, 2022
@wfondrie wfondrie deleted the mod_detokenize branch November 15, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants