-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to dekonize peptide into AA list #22
Conversation
@wfondrie Should I add a unit test for |
The above previous errors were due to a failure to upload test coverage to CodeCov, which hopefully I've fixed now 🤞
The answer to this question is always yes 😉 |
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 19 19
Lines 854 854
=======================================
Hits 743 743
Misses 111 111
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is there a good reason to every return a string? It seems like we should just make it always return a list. It seems easy enough for the user to join the string if they desire. 🤔 I'd ok with the breaking change for now, since I think Casanovo is currently the only dependent. What do you think @melihyilmaz and @bittremieux? |
I concur. |
Makes sense we can only return a list, I added it as an option earlier to avoid breaking things down. |
Added option for
detokenize
to return peptide sequence as a list of amino acids rather than only in the string format. This was needed in the context of Casanovo for cases where multiple N-terminal modifications are predicted back to back (e.g. -17.027+42.011) and the downstream regex logic fails to differentiate these PTMs. Refer to below discussion for more details:Noble-Lab/casanovo#87 (comment)