Gate WASM module behinde feature flag #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you'd prefer this can probably be adjusted to be gated both ways such that WASM is a feature but on by default and further gated by the target. For most people that would mean not having to change their build arguments from what they are now, and allow me to use no-default-features to disable it. |
|
I just tried building on my side with a Git dependency pointing at this branch and it does seem to have resolved by duplicate symbols linker problem. That doesn't mean I didn't break anything else, but it does seem to fix the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't tested yet, but it's roughly what I think would address my problem and close #26.