-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right control button is detected as the left control button #2009
Comments
Sounds like a duplicate of #1904 |
@wez microsoft/terminal#13134 I hope I did it okey enough to move this forward. |
Thanks! |
refs: microsoft/terminal#13134 refs: #1904 refs: #1509 refs: #2009
I pushed a commit that fixes the main issue behind the other win32 input mode bugs reported to wezterm, where CTRL- wasn't correctly reported. Could you try that and let me know if that resolves what you're seeing with the left/right ctrl key issue? wezterm doesn't track a distinct left/right ctrl modifier mask (because that concept isn't part of the classic terminal model), but if you're pressing just the left/right ctrl key (and not using it as a modifier) it should pass through the underlying vkey code. It typically takes about an hour before fixes are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer. Please take a few moments to try out the fix and let me know how that works out. If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a If you are eager and can build from source then you may be able to try this out more quickly. |
Can you clarify for me what key(s) you're pressing in this situation? |
Could you also turn on |
I think this might only be a thing on Windows. This commit speculatively (I'm on a mac at the moment!) allows tracking the left/right control/shift modifier flags and passing that through to the win32 input mode logic. refs: #2009
Yes, for Far, we use a left control + a number for example to change the panels and right control + a number to navigate to favourites. That is why is important the distinction. |
Can you try downloading the latest nightly build? I landed a change that might help |
One more note, the control + up key is not working. I was wondering if this might be related. |
Can you show the debug key events logs for that key combo when you try it? |
Hi @wez do you think it is possible? |
Asking over in microsoft/terminal#13134 (comment) |
I think this is fixed now in |
Yes!, it is working man, this is fantastic! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What Operating System(s) are you seeing this problem on?
Windows
WezTerm version
20220408-101518-b908e2dd
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
No, and I'll explain why below
Describe the bug
Currently, when I am using Far manager, I loved Wezterm but the right control button is not been detected independently which is needed so much to move between favorite groups.
Is it possible to register that key differently from the left control one?
To Reproduce
No response
Configuration
local wezterm = require 'wezterm';
return {
disable_default_key_bindings = true,
allow_win32_input_mode = true,
}
Expected Behavior
No response
Logs
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: