Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix automatic package detection with yarn^3 #1886

Merged
merged 4 commits into from
Feb 20, 2023
Merged

Conversation

roninjin10
Copy link
Contributor

@roninjin10 roninjin10 commented Feb 20, 2023

Description

In a previous pr we fixed one bug about yarn 3.0 but there is another one. yarn list does not exist in yarn berry

Fix: use yarn why instead

test

I yarn linked my wagmi and tried on the repro
image

  • I also changed the package name hardhat to 'asdfasdf' to test that validation still fails
  • I also verified yarn why exists in yarn classic

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2023

🦋 Changeset detected

Latest commit: 2dff95d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wagmi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 20, 2023

Someone is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@roninjin10 roninjin10 changed the title Willc/why fix: Fix automatic package detection with yarn^3 Feb 20, 2023
.changeset/eight-vans-taste.md Outdated Show resolved Hide resolved
@tmm tmm merged commit 36e119c into wevm:main Feb 20, 2023
@technophile-04
Copy link
Contributor

Tysm @roninjin10, @tmm the new version is not published yet right?

Thanks guys 🙌

@roninjin10
Copy link
Contributor Author

Yup it didn’t get published right away but you should see the changes now or next time wagmi published

@technophile-04
Copy link
Contributor

Tysm @roninjin10, yup the new @wagmi-cli has been pushed as 0.1.9 and seems to fix the issue 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants