fix(cli): generated chain key type #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dd77b9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmm
force-pushed
the
tmm/cli-generated-chain-type
branch
from
40d0bf9 to
dd77b9c
Compare
tmm
commented
Jan 26, 2023
Comment on lines
-5
to
+9
| "build": "pnpm -r --filter '@wagmi/chains' build && pnpm -r --filter '@wagmi/core' build && pnpm -r --filter './packages/**' --filter './references/packages/**' build", | ||
| "build": "pnpm --filter '@wagmi/chains' build && pnpm --filter '@wagmi/core' build && pnpm -r --filter './packages/**' --filter './references/**' --filter '!./packages/core' --filter '!./references/**/chains' build", | ||
| "changeset:release": "pnpm build && changeset publish", | ||
| "changeset:version": "changeset version && pnpm install --lockfile-only", | ||
| "cjs:release": "node -r esbuild-register ./scripts/cjs.ts", | ||
| "dev": "pnpm -r --filter '@wagmi/chains' build && pnpm -r --filter '@wagmi/connectors' --filter './packages/**' dev", | ||
| "dev": "pnpm --filter '@wagmi/chains' build && pnpm -r --filter './packages/**' --filter './references/**' --filter '!./references/**/chains' dev", |
There was a problem hiding this comment.
Cleaned up these scripts. Have some dependencies that pnpm is able to map out correctly with topo sort so handling it here.
tmm
commented
Jan 26, 2023
| @@ -68,7 +68,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@ethersproject/address": "^5.7.0", | |||
| "@wagmi/chains": "^0.2.0", | |||
| "@wagmi/chains": "workspace:../../references/packages/chains", | |||
There was a problem hiding this comment.
Use workspace version instead of pinned
tmm
commented
Jan 26, 2023
| /^\s*"(\d)":/gm, | ||
| '$1:', | ||
| ) | ||
| JSON.stringify(resolvedAddress, null, 2).replace(/"(\d*)":/gm, '$1:') |
There was a problem hiding this comment.
regex i used before only worked for single digits 🤦♂️
this one is much better: https://regexr.com/7700l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix generated address object key type so it's alway a number. (Won't be a number in JS
Object.keysstill, which is fine. Just need it to be for type inference.)Additional Information
Your ENS/address: awkweb.eth